sway-unwrapped: rename wlroots_0_16 argument to wlroots#237044
Merged
teto merged 3 commits intoNixOS:masterfrom Jun 25, 2023
Merged
sway-unwrapped: rename wlroots_0_16 argument to wlroots#237044teto merged 3 commits intoNixOS:masterfrom
teto merged 3 commits intoNixOS:masterfrom
Conversation
6 tasks
teto
force-pushed
the
config-sway-via-attributes
branch
2 times, most recently
from
6c9f970 to
f132a27
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
Author
|
cc @primeos |
primeos
reviewed
Jun 12, 2023
Member
primeos
left a comment
primeos
left a comment
There was a problem hiding this comment.
Hm, I'm not entirely convinced on inheriting the "config/override flags" (would be better if we already had a proper mechanism for package configuration flags in Nixpkgs) but I don't really mind so feel free to merge if it helps for your / the home-manager use-case ;)
(But those arguments aren't guaranteed to remain stable so relying on them is a bit dangerous - we try to avoid even such (internal) "breaking" changes to the Sway package though.)
It's a bit unfortunate that we loose the assert but it should be fine.
teto
force-pushed
the
config-sway-via-attributes
branch
from
f132a27 to
3cb718c
Compare
added 3 commits
June 15, 2023 16:50
makes it easier to change.
it's easier to use overrideAttrs than override IMO, and for the home-manager module I would like to be able to configure sway forks the same way as the original sway which is not possible currently see nix-community/home-manager#4039
teto
force-pushed
the
config-sway-via-attributes
branch
from
3cb718c to
898559e
Compare
Member
Author
|
@primeos gentle ping |
Member
|
Sorry for the delay, my backlog ist too large :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
this makes the override of settings possible via overrideAttrs rather than override making the interface easier and also making this possible nix-community/home-manager#4039 i.e., having home-manager configure swayfx in the same way it configures sway.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)