Skip to content

onlykey: 5.3.4 -> 5.5.0 and use NodeJS-18#236329

Merged
kalbasit merged 2 commits intoNixOS:masterfrom
kalbasit:personal/soxincfg/update-23.05/onlykey
Jun 7, 2023
Merged

onlykey: 5.3.4 -> 5.5.0 and use NodeJS-18#236329
kalbasit merged 2 commits intoNixOS:masterfrom
kalbasit:personal/soxincfg/update-23.05/onlykey

Conversation

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Jun 6, 2023

Description of changes

The previous package was built with NodeJS 14 which is EOL. I've also taken this opportunity to update the package to its latest version.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit marked this pull request as ready for review June 6, 2023 19:16
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 6, 2023
@kalbasit kalbasit force-pushed the personal/soxincfg/update-23.05/onlykey branch from 3f0c0de to 31b940e Compare June 6, 2023 21:32
@kalbasit kalbasit merged commit ab85158 into NixOS:master Jun 7, 2023
@kalbasit kalbasit deleted the personal/soxincfg/update-23.05/onlykey branch June 7, 2023 06:01
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Successfully created backport PR for release-23.05:

@K900
Copy link
Contributor

K900 commented Jun 7, 2023

This broke eval.

@fabaff
Copy link
Member

fabaff commented Jun 7, 2023

[...]
       error: attribute 'nodejs-18_x' missing

       at /home/fab/.cache/nixpkgs-review/pr-236416/nixpkgs/pkgs/tools/security/onlykey/onlykey.nix:5:48:

            4|     inherit system;
            5|   }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-18_x"}:

@vcunat
Copy link
Member

vcunat commented Jun 7, 2023

For reference, fixed in PR #236418

@vcunat
Copy link
Member

vcunat commented Jun 7, 2023

Generally, I would be careful about merging nontrivial backport PRs immediately when merging the same changes to master.

@kalbasit
Copy link
Member Author

kalbasit commented Jun 7, 2023

Hmm that's odd. The CI marked it green 🤔

@vcunat
Copy link
Member

vcunat commented Jun 7, 2023

Yes, it's known that the CI doesn't check this in all places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants