onlykey: 5.3.4 -> 5.5.0 and use NodeJS-18#236329
Merged
kalbasit merged 2 commits intoNixOS:masterfrom Jun 7, 2023
Merged
Conversation
3f0c0de to
31b940e
Compare
1 task
Contributor
|
Successfully created backport PR for |
Contributor
|
This broke eval. |
Member
[...]
error: attribute 'nodejs-18_x' missing
at /home/fab/.cache/nixpkgs-review/pr-236416/nixpkgs/pkgs/tools/security/onlykey/onlykey.nix:5:48:
4| inherit system;
5| }, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-18_x"}: |
Member
|
For reference, fixed in PR #236418 |
Member
|
Generally, I would be careful about merging nontrivial backport PRs immediately when merging the same changes to master. |
Member
Author
|
Hmm that's odd. The CI marked it green 🤔 |
Member
|
Yes, it's known that the CI doesn't check this in all places. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The previous package was built with NodeJS 14 which is EOL. I've also taken this opportunity to update the package to its latest version.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)