Skip to content

racket: disable on darwin#23612

Closed
henrytill wants to merge 1 commit intoNixOS:masterfrom
henrytill:racket-disable-on-darwin
Closed

racket: disable on darwin#23612
henrytill wants to merge 1 commit intoNixOS:masterfrom
henrytill:racket-disable-on-darwin

Conversation

@henrytill
Copy link
Member

Motivation for this change

Darwin builds of Racket are segfaulting for unknown reasons:
https://hydra.nixos.org/build/49778947

I don't have the capacity to troubleshoot this issue ATM. Anyone with the capacity is more than welcome to try to fix the build, but until such a person steps forward, I am proposing that we simply disable builds on Darwin.

Aside from updating the meta.platforms attribute, I have kept other bits of Darwin-specific code intact so that they will not be lost to the sands of time.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@henrytill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gridaphobe, @aske and @letac to be potential reviewers.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 7, 2017
@LnL7
Copy link
Member

LnL7 commented Mar 7, 2017

I personally prefer not to change the platforms for packages that should work.

@LnL7 LnL7 self-assigned this Mar 7, 2017
@LnL7
Copy link
Member

LnL7 commented Mar 7, 2017

This should be fixed by #22571.

@henrytill
Copy link
Member Author

This should be fixed by #22571.

A much better solution!

@henrytill henrytill closed this Mar 7, 2017
@henrytill henrytill deleted the racket-disable-on-darwin branch March 7, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants