haskellPackages.mkDerivation: small clean up#235263
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Jun 1, 2023
Merged
haskellPackages.mkDerivation: small clean up#235263maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
figsoda
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
Member
cdepillabout
left a comment
cdepillabout
left a comment
There was a problem hiding this comment.
Thanks, this cleanup LGTM!
Could you rebase this on the haskell-updates branch? We generally ask that all haskell-related changes be made to the haskell-updates branch.
cdepillabout
approved these changes
May 31, 2023
ofborg
bot
added
10.rebuild-darwin: 11-100
Gabriella439
approved these changes
Jun 1, 2023
maralorn
reviewed
Jun 1, 2023
| ]; | ||
|
|
||
| postPhases = optional doInstallIntermediates [ "installIntermediatesPhase" ]; | ||
| postPhases = optional doInstallIntermediates "installIntermediatesPhase"; |
Member
Author
There was a problem hiding this comment.
it basically changes the value from [ [ "installIntermediatesPhase" ] ] to [ "installIntermediatesPhase" ], so it should be a no-op since it gets turned into a string
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)