Skip to content

Comments

emscripten: 3.1.39 -> 3.1.40#235216

Closed
willcohen wants to merge 2 commits intoNixOS:stagingfrom
willcohen:emscripten-3.1.40
Closed

emscripten: 3.1.39 -> 3.1.40#235216
willcohen wants to merge 2 commits intoNixOS:stagingfrom
willcohen:emscripten-3.1.40

Conversation

@willcohen
Copy link
Contributor

@willcohen willcohen commented May 31, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@willcohen willcohen changed the base branch from master to staging May 31, 2023 15:06
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels May 31, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 31, 2023
@willcohen willcohen force-pushed the emscripten-3.1.40 branch from 63c1c57 to 0f06acf Compare May 31, 2023 17:49
@willcohen willcohen marked this pull request as draft May 31, 2023 17:56
@willcohen
Copy link
Contributor Author

willcohen commented May 31, 2023

3.1.40 is broken due to emscripten-core/emscripten#19466, will require backport to LLVM.

@willcohen
Copy link
Contributor Author

willcohen commented May 31, 2023

Backport request: llvm/llvm-project#63040

@willcohen willcohen mentioned this pull request May 31, 2023
Merged
12 tasks
@willcohen willcohen force-pushed the emscripten-3.1.40 branch from 0f06acf to 2f6dde3 Compare June 1, 2023 01:25
@willcohen
Copy link
Contributor Author

willcohen commented Jun 1, 2023

Turns out trying to rebuild other packages on top of 3.1.39 actually requires the LLVM backports. Updated this to address that issue accordingly, though the backport is now dependent on #235219.

@willcohen
Copy link
Contributor Author

willcohen commented Jun 1, 2023 •
edited
Loading

LLVM backport request was approved. This should make it into 16.0.5. I'll leave this as draft until a new LLVM point release is cut, which can be a followup to #235219. After that, I can remove the backports from this PR and have it cleanly just update emscripten.

@willcohen
Copy link
Contributor Author

willcohen commented Jun 2, 2023

Updated #235219 to llvm 16.0.5.

@willcohen
Copy link
Contributor Author

willcohen commented Jun 22, 2023

Closing in favor of #235624.

@willcohen willcohen closed this Jun 22, 2023
@willcohen willcohen deleted the emscripten-3.1.40 branch July 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@qknight qknight Awaiting requested review from qknight

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@willcohen