Skip to content

Comments

Update http3 libraries#234645

Merged
wegank merged 3 commits intoNixOS:staging-nextfrom
Izorkin:update-http3-libs
May 28, 2023
Merged

Update http3 libraries#234645
wegank merged 3 commits intoNixOS:staging-nextfrom
Izorkin:update-http3-libs

Conversation

@Izorkin
Copy link
Contributor

@Izorkin Izorkin commented May 28, 2023

Description of changes

Update nghttp3 to version 0.11.0.
Update ngtcp2 to version 0.15.0.
Small update nginx-http3 test.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 28, 2023
@Izorkin Izorkin requested a review from vcunat May 28, 2023 16:30
@vcunat
Copy link
Member

vcunat commented May 28, 2023

I believe this would better go to staging-next. It shouldn't be a big rebuild, and it's where the curl update is currently.

@Izorkin Izorkin marked this pull request as draft May 28, 2023 16:55
@Izorkin Izorkin force-pushed the update-http3-libs branch from 351c23a to f28c987 Compare May 28, 2023 16:55
@Izorkin Izorkin changed the base branch from staging to staging-next May 28, 2023 16:55
@Izorkin Izorkin marked this pull request as ready for review May 28, 2023 16:56
@Izorkin
Copy link
Contributor Author

Izorkin commented May 28, 2023

Rebased PR.

vcunat
vcunat approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and fixes curlHTTP3 for me. /cc PR #232531

@vcunat vcunat mentioned this pull request May 28, 2023
Merged
1 task
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 28, 2023
@Izorkin
Copy link
Contributor Author

Izorkin commented May 28, 2023

@GrahamcOfBorg test nginx-http3

@wegank wegank merged commit b8ce4c4 into NixOS:staging-next May 28, 2023
@github-actions github-actions bot mentioned this pull request May 28, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2023

Successfully created backport PR for staging-23.05:

@Izorkin Izorkin deleted the update-http3-libs branch May 29, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Izorkin @vcunat @wegank