acme-dns: init at 1.0; nixos/acme-dns: init; nixos/acme-dns: init#234207
Merged
kira-bruneau merged 3 commits intoNixOS:masterfrom May 31, 2023
Merged
acme-dns: init at 1.0; nixos/acme-dns: init; nixos/acme-dns: init#234207kira-bruneau merged 3 commits intoNixOS:masterfrom
kira-bruneau merged 3 commits intoNixOS:masterfrom
Conversation
Member
Author
|
@ofborg test acme-dns |
leona-ya
approved these changes
May 26, 2023
kira-bruneau
approved these changes
May 30, 2023
Contributor
kira-bruneau
left a comment
There was a problem hiding this comment.
This looks great! I'd actually be happy to merge this as-is, but also made a couple comments for some things that popped out to me.
kira-bruneau
approved these changes
May 31, 2023
Member
|
Maybe we could mention this service in the manual section on DNS-01? |
Member
Author
|
Hmmm I guess we could do something like that. Are you thinking of a full-blown detailed example, or just a mere mention? |
Member
|
If it's possible (and simple enough) to use acme-dns to replace the BIND-based workflow, then I think it would be nice to document how to do that, at least as an alternative. However I am not familiar with the process at all; it seems like you might also need to use acme-dns-client? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Previously (2020): #83474
https://github.com/joohoi/acme-dns
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)