Skip to content

acme-dns: init at 1.0; nixos/acme-dns: init; nixos/acme-dns: init#234207

Merged
kira-bruneau merged 3 commits intoNixOS:masterfrom
emilylange:acme-dns
May 31, 2023
Merged

acme-dns: init at 1.0; nixos/acme-dns: init; nixos/acme-dns: init#234207
kira-bruneau merged 3 commits intoNixOS:masterfrom
emilylange:acme-dns

Conversation

@emilylange
Copy link
Member

Description of changes

Previously (2020): #83474

https://github.com/joohoi/acme-dns

A simplified DNS server with a RESTful HTTP API to provide a simple way to automate ACME DNS challenges.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 26, 2023
@emilylange
Copy link
Member Author

@ofborg test acme-dns

@emilylange emilylange mentioned this pull request May 26, 2023
10 tasks
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 26, 2023
Copy link
Contributor

@kira-bruneau kira-bruneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'd actually be happy to merge this as-is, but also made a couple comments for some things that popped out to me.

@github-actions github-actions bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels May 31, 2023
@emilylange emilylange marked this pull request as ready for review May 31, 2023 13:09
@emilylange emilylange requested a review from kira-bruneau May 31, 2023 13:11
@kira-bruneau kira-bruneau merged commit 7e82061 into NixOS:master May 31, 2023
@emilylange emilylange deleted the acme-dns branch May 31, 2023 15:41
@ncfavier
Copy link
Member

ncfavier commented Jun 5, 2023

Maybe we could mention this service in the manual section on DNS-01?

@emilylange
Copy link
Member Author

Hmmm I guess we could do something like that.

Are you thinking of a full-blown detailed example, or just a mere mention?
Ref: https://go-acme.github.io/lego/dns/acme-dns/

@ncfavier
Copy link
Member

ncfavier commented Jun 6, 2023

If it's possible (and simple enough) to use acme-dns to replace the BIND-based workflow, then I think it would be nice to document how to do that, at least as an alternative.

However I am not familiar with the process at all; it seems like you might also need to use acme-dns-client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants