Skip to content

Comments

haskellPackages.yesod-core: fix build with Darwin sandbox enabled#234129

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
reckenrode:yesod-core-darwin-sandbox-fix
May 26, 2023
Merged

haskellPackages.yesod-core: fix build with Darwin sandbox enabled#234129
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
reckenrode:yesod-core-darwin-sandbox-fix

Conversation

@reckenrode
Copy link
Contributor

Description of changes

yesod-core needs to run a server on localhost during tests.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = relaxed set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 26, 2023
@cdepillabout cdepillabout added the 6.topic: darwin Running or building packages on Darwin label May 26, 2023
@reckenrode reckenrode force-pushed the yesod-core-darwin-sandbox-fix branch from de4814f to d1f3d13 Compare May 26, 2023 03:57
@reckenrode reckenrode changed the base branch from master to haskell-updates May 26, 2023 03:57
@reckenrode reckenrode force-pushed the yesod-core-darwin-sandbox-fix branch from d1f3d13 to 217ed54 Compare May 26, 2023 03:58
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 26, 2023
@mikroskeem
Copy link
Member

Result of nixpkgs-review pr 234129 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • datalad
  • datalad.dist
8 packages failed to build:
  • git-annex (haskellPackages.git-annex)
  • git-annex.doc (haskellPackages.git-annex.doc)
  • haskellPackages.yesod-auth-hashdb
  • haskellPackages.yesod-auth-hashdb.doc
  • python310Packages.git-annex-adapter
  • python310Packages.git-annex-adapter.dist
  • python311Packages.git-annex-adapter
  • python311Packages.git-annex-adapter.dist
90 packages built:
  • haskellPackages.bugsnag-yesod
  • haskellPackages.bugsnag-yesod.doc
  • haskellPackages.classy-prelude-yesod
  • haskellPackages.classy-prelude-yesod.doc
  • haskellPackages.espial
  • haskellPackages.espial.doc
  • haskellPackages.fluffy
  • haskellPackages.fluffy.data
  • haskellPackages.fluffy.doc
  • haskellPackages.hledger-web
  • haskellPackages.hledger-web.doc
  • haskellPackages.hs-opentelemetry-instrumentation-yesod
  • haskellPackages.hs-opentelemetry-instrumentation-yesod.doc
  • haskellPackages.rowdy-yesod
  • haskellPackages.rowdy-yesod.doc
  • haskellPackages.serversession-frontend-yesod
  • haskellPackages.serversession-frontend-yesod.doc
  • haskellPackages.yesod
  • haskellPackages.yesod-alerts
  • haskellPackages.yesod-alerts.doc
  • haskellPackages.yesod-auth
  • haskellPackages.yesod-auth-basic
  • haskellPackages.yesod-auth-basic.doc
  • haskellPackages.yesod-auth-lti13
  • haskellPackages.yesod-auth-lti13.doc
  • haskellPackages.yesod-auth-oauth
  • haskellPackages.yesod-auth-oauth.doc
  • haskellPackages.yesod-auth-oauth2
  • haskellPackages.yesod-auth-oauth2.doc
  • haskellPackages.yesod-auth.doc
  • haskellPackages.yesod-autoreload
  • haskellPackages.yesod-autoreload.doc
  • haskellPackages.yesod-core
  • haskellPackages.yesod-core.doc
  • haskellPackages.yesod-default
  • haskellPackages.yesod-default.doc
  • haskellPackages.yesod-elements
  • haskellPackages.yesod-elements.doc
  • haskellPackages.yesod-eventsource
  • haskellPackages.yesod-eventsource.doc
  • haskellPackages.yesod-fb
  • haskellPackages.yesod-fb.doc
  • haskellPackages.yesod-form
  • haskellPackages.yesod-form-bootstrap4
  • haskellPackages.yesod-form-bootstrap4.doc
  • haskellPackages.yesod-form-bulma
  • haskellPackages.yesod-form-bulma.doc
  • haskellPackages.yesod-form-multi
  • haskellPackages.yesod-form-multi.doc
  • haskellPackages.yesod-form.doc
  • haskellPackages.yesod-gitrepo
  • haskellPackages.yesod-gitrepo.doc
  • haskellPackages.yesod-json
  • haskellPackages.yesod-json.doc
  • haskellPackages.yesod-markdown
  • haskellPackages.yesod-markdown.doc
  • haskellPackages.yesod-media-simple
  • haskellPackages.yesod-media-simple.doc
  • haskellPackages.yesod-newsfeed
  • haskellPackages.yesod-newsfeed.doc
  • haskellPackages.yesod-page-cursor
  • haskellPackages.yesod-page-cursor.doc
  • haskellPackages.yesod-paginator
  • haskellPackages.yesod-paginator.doc
  • haskellPackages.yesod-persistent
  • haskellPackages.yesod-persistent.doc
  • haskellPackages.yesod-recaptcha2
  • haskellPackages.yesod-recaptcha2.doc
  • haskellPackages.yesod-routes-flow
  • haskellPackages.yesod-routes-flow.doc
  • haskellPackages.yesod-sitemap
  • haskellPackages.yesod-sitemap.doc
  • haskellPackages.yesod-static
  • haskellPackages.yesod-static.doc
  • haskellPackages.yesod-table
  • haskellPackages.yesod-table.doc
  • haskellPackages.yesod-tableview
  • haskellPackages.yesod-tableview.doc
  • haskellPackages.yesod-test
  • haskellPackages.yesod-test.doc
  • haskellPackages.yesod-websockets
  • haskellPackages.yesod-websockets-extra
  • haskellPackages.yesod-websockets-extra.doc
  • haskellPackages.yesod-websockets.doc
  • haskellPackages.yesod.doc
  • haskellPackages.ytl
  • haskellPackages.ytl.doc
  • haskellPackages.yu-utils
  • haskellPackages.yu-utils.doc
  • hledger-web

nix run nixpkgs#nixpkgs-review -- pr 234129 --build-args '--relaxed-sandbox'

@cdepillabout
Copy link
Member

Thanks!

@cdepillabout cdepillabout merged commit 74af609 into NixOS:haskell-updates May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants