fish: fix build with Darwin sandbox enabled#234119
Merged
cole-h merged 1 commit intoNixOS:masterfrom Jun 9, 2023
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 11-100
winterqt
approved these changes
May 26, 2023
Contributor
Author
I don’ think it does. I’m using |
Member
|
I said that because it worked fine with my configuration, where it is true... odd. |
Contributor
Author
Huh. That is odd. |
This was referenced May 26, 2023
mweinelt
added
12.approvals: 1
cole-h
approved these changes
Jun 9, 2023
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
LGTM, thanks! I also tested with sandbox = true (before and after this commit) and it does indeed fix it. (Built natively before and after on aarch64-darwin, but only after through Rosetta for x86_64-darwin.)
Maybe sandboxProfile is always intended to be allowed 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
fish’s test suite has numerous failures when run on a Darwin machine with the sandbox enabled. The sandbox profile allows the test suite to run successfully.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)