pinentry-mac: fix build with Darwin sandbox enabled#234111
Merged
wegank merged 1 commit intoNixOS:masterfrom May 27, 2023
Merged
pinentry-mac: fix build with Darwin sandbox enabled#234111wegank merged 1 commit intoNixOS:masterfrom
wegank merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
6.topic: darwin
16 tasks
wegank
reviewed
May 26, 2023
reckenrode
force-pushed
the
pinentry-mac-darwin-sandbox
branch
from
c0d6e66 to
7ca376e
Compare
reckenrode
force-pushed
the
pinentry-mac-darwin-sandbox
branch
from
7ca376e to
8f84341
Compare
Member
|
@ofborg build pinentry_mac gnupg22 gnupg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
pinentry-mac needs PlistBuddy to build and hardcodes the system one at
/usr/libexec/PlistBuddy. I tried to replace it with the one from xcbuild, but that version didn’t like the arguments the pinentry-mac build process was trying to pass to it.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)