Skip to content

hledger_1_29_2: fix dependency toward hledger-lib#233623

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
DamienCassou:fix-hledger_1_29_2
May 25, 2023
Merged

hledger_1_29_2: fix dependency toward hledger-lib#233623
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
DamienCassou:fix-hledger_1_29_2

Conversation

@DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented May 23, 2023 •
edited
Loading

Description of changes

hledger version X always depends on hledger-lib version X.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 23, 2023
@DamienCassou
Copy link
Contributor Author

DamienCassou commented May 23, 2023

Result of nixpkgs-review pr 233623 run on x86_64-linux 1

@DamienCassou DamienCassou marked this pull request as ready for review May 23, 2023 14:16
sternenseemann
sternenseemann requested changes May 23, 2023
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hackage-packages.nix is generated and will be rolled back.

Such changes need to be implemented using an override in one of the overlays applied to the package set.

@DamienCassou DamienCassou added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label May 23, 2023
@DamienCassou
hledger_1_29_2: fix dependency toward hledger-lib
aa047eb 
hledger version X always depends on hledger-lib version X.
@DamienCassou
Copy link
Contributor Author

DamienCassou commented May 23, 2023

Result of nixpkgs-review pr 233623 run on x86_64-linux 1

@DamienCassou
Copy link
Contributor Author

DamienCassou commented May 23, 2023

hackage-packages.nix is generated and will be rolled back.
Such changes need to be implemented using an override in one of the overlays applied to the package set.

is it better now @sternenseemann?

@DamienCassou DamienCassou changed the title hledger: fix dependency toward hledger-lib hledger_1_29_2: fix dependency toward hledger-lib May 23, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 23, 2023
@DamienCassou
Copy link
Contributor Author

DamienCassou commented May 24, 2023 •
edited
Loading

I think we should merge that quickly to be on time for the release. If nobody else reviews, I will just merge.

@sternenseemann
Copy link
Member

sternenseemann commented May 25, 2023

@ofborg build haskellPackages.hledger_1_29_2

@sternenseemann
Copy link
Member

sternenseemann commented May 25, 2023

Can you target haskell-updates? For 23.05 a backport is required anyways.

@DamienCassou DamienCassou changed the base branch from master to haskell-updates May 25, 2023 07:08
@DamienCassou
Copy link
Contributor Author

DamienCassou commented May 25, 2023

Can you target haskell-updates? For 23.05 a backport is required anyways.

I changed the target branch. Anything else I should do?

@cdepillabout
Copy link
Member

cdepillabout commented May 25, 2023

Thanks!

@cdepillabout cdepillabout merged commit 0d1d890 into NixOS:haskell-updates May 25, 2023
@github-actions github-actions bot mentioned this pull request May 25, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2023

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DamienCassou @sternenseemann @cdepillabout