Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipboard-jh: fixed broken system clipboard integration #233262

Merged
merged 1 commit into from
May 21, 2023
Merged

clipboard-jh: fixed broken system clipboard integration #233262

merged 1 commit into from
May 21, 2023

Conversation

heinwol
Copy link
Contributor

@heinwol heinwol commented May 21, 2023

fixes #229659 as well as Slackadays/Clipboard#117

Description of changes
  • fixed rpath of $out/bin/cb by adding $out/lib explicitly via patchelf
  • added patchelf dependency, obviously
Things done

Tested on my machine (x11, kde), works as previously but now one can e.g. write cb p | cat with something in system clipboard and it will actually be pasted. Should work fine on wayland as well.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@heinwol
Copy link
Contributor Author

heinwol commented May 21, 2023

Well, I see I've missed some trailing spaces. What's better to do now? Close the pr and open a new one or can I simply make a commit on top of that? Is there a way to just edit this commit?

@StrictlyMonad
Copy link

StrictlyMonad commented May 21, 2023

Well, I see I've missed some trailing spaces. What's better to do now?

@heinwol just amend (no reword) changes to current commit and force push.

@figsoda figsoda merged commit 9689eb7 into NixOS:master May 21, 2023
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clipboard-jh package: Opening libcbx11.so to look for setX11Clipboard failed, aborting operation
5 participants