Skip to content

lib/licenses: Business Source License 1.1 is redistributable#233050

Merged
RaitoBezarius merged 1 commit intomasterfrom
bsl-is-redistributable
May 22, 2023
Merged

lib/licenses: Business Source License 1.1 is redistributable#233050
RaitoBezarius merged 1 commit intomasterfrom
bsl-is-redistributable

Conversation

@RaitoBezarius
Copy link
Member

Description of changes

Feel free to bikeshed me.
It is written in its text, still unfree though and cannot be used for production.

At the request here: #232235.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

It is written in its text, still unfree though and cannot be used for *production*.
@RaitoBezarius RaitoBezarius requested a review from alyssais as a code owner May 20, 2023 17:01
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2023
@cab404
Copy link
Member

cab404 commented May 21, 2023

Heh, we can also parametrize it with a date and a fallback license, so to automatically switch it to fallback license using the date from git)

@RaitoBezarius
Copy link
Member Author

Heh, we can also parametrize it with a date and a fallback license, so to automatically switch it to fallback license using the date from git)

I don't understand what you mean by that, can you clarify?

@cab404
Copy link
Member

cab404 commented May 21, 2023

I don't understand what you mean by that, can you clarify?

BSL is actually a parametrized license. You can choose "Change" license, which takes force after BSL period (also a parameter) ends.

@RaitoBezarius
Copy link
Member Author

oh lord that's much more complicated than the scope of this PR, can you open a follow up for that?

@cab404
Copy link
Member

cab404 commented May 21, 2023

oh lord that's much more complicated than the scope of this PR, can you open a follow up for that?

You've added a request for bikeshedding ;D
But yeah, I agree)

@RaitoBezarius
Copy link
Member Author

You've added a request for bikeshedding ;D

true :DDDD — but I didn't expect "implement this whole changing license mechanism" as a bikeshedding to redistribution :P

@alyssais
Copy link
Member

In practice I don't think the change date mechanism is meaningful, and trying to represent it in Nixpkgs is likely to result in more inaccurate license info. The change date tends to be frequently bumped, so unless we don't upgrade in Nixpkgs, or upstream stops releasing (or forgets to update its change date), the version we package in Nixpkgs will never be available under the fallback license. I don't think people are going to remember to check the new change date every time they update a package, so I'd expect change dates recorded in Nixpkgs to quickly become incorrect.

@RaitoBezarius
Copy link
Member Author

In practice I don't think the change date mechanism is meaningful, and trying to represent it in Nixpkgs is likely to result in more inaccurate license info. The change date tends to be frequently bumped, so unless we don't upgrade in Nixpkgs, or upstream stops releasing (or forgets to update its change date), the version we package in Nixpkgs will never be available under the fallback license. I don't think people are going to remember to check the new change date every time they update a package, so I'd expect change dates recorded in Nixpkgs to quickly become incorrect.

Hmm, I might be misunderstanding this but isn't the Change Date some "target limit date"? If you release a version 1, and something happens where you release version 2, 3, 4, 5, 6, after the 4th anniversary of version 1, all versions gets fallback license?

If it's not the case, I definitely agree with you then.

@alyssais
Copy link
Member

alyssais commented May 22, 2023 via email

@RaitoBezarius
Copy link
Member Author

Hmm, I might be misunderstanding this but isn't the Change Date some "target limit date"? If you release a version 1, and something happens where you release version 2, 3, 4, 5, 6, after the 4th anniversary of version 1, all versions gets fallback license?
The way it usually works is that upstream will pick some duration, like 3 years, and then each release will have a change date attached that's 3 years from when that release is made. So if v1 comes out in 2023, and v2 comes out in 2024, you could use v1 under the fallback license from 2026, and v2 from 2027. So if you're keeping up to date, the fallback license is irrelevant. It's only useful if upstream dies, or if you want to run an old version. Does that answer your question?

Yes, works for me, so I guess, let's not do it.

Could I get you to approve this PR which is only about making BSL11 redistributable?

@RaitoBezarius RaitoBezarius merged commit f4520c5 into master May 22, 2023
@yu-re-ka yu-re-ka deleted the bsl-is-redistributable branch May 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants