Skip to content

goose: init at 3.11.2#232485

Merged
yu-re-ka merged 1 commit intoNixOS:masterfrom
yu-re-ka:goose
May 17, 2023
Merged

goose: init at 3.11.2#232485
yu-re-ka merged 1 commit intoNixOS:masterfrom
yu-re-ka:goose

Conversation

@yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented May 17, 2023 •
edited
Loading

Description of changes

Tested functionality

Can not figure out how to make goose -version output the correct thing

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka requested a review from figsoda May 17, 2023 19:57
figsoda
figsoda reviewed May 17, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nitpicks

@yu-re-ka yu-re-ka requested a review from figsoda May 17, 2023 20:07
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 17, 2023
figsoda
figsoda reviewed May 17, 2023
View reviewed changes
Copy link
Member

@figsoda figsoda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the build on darwin

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented May 17, 2023

Thanks!

@figsoda
Copy link
Member

figsoda commented May 17, 2023

oops stdenv needs to be added to the inputs

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented May 17, 2023

oops stdenv needs to be added to the inputs

done

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented May 17, 2023

@ofborg build goose

@yu-re-ka yu-re-ka merged commit 1d77f3b into NixOS:master May 17, 2023
@yu-re-ka yu-re-ka deleted the goose branch May 17, 2023 22:51
@geekodour geekodour mentioned this pull request Apr 15, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@figsoda figsoda figsoda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yu-re-ka @figsoda @yuyuyureka