Python package set bootstrap update#232451
Conversation
The flit-core build is getting more adoption lately, which leads to otherwise unresolvable cyclic dependency chains.
and make sure that flit has a deterministic output name.
github-actions
bot
added
the
6.topic: python
|
|
||
| buildPhase = '' | ||
| runHook preBuild | ||
| ${python.interpreter} -m flit_core.wheel |
There was a problem hiding this comment.
Don't we need forBuild here?
| ${python.interpreter} -m flit_core.wheel | |
| ${python.pythonForBuild.interpreter} -m flit_core.wheel |
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
good idea and good to adopt those packages into the team
| hash = "sha256-iXf9K/xI4u+dDV0Zf6S08nbws4NqycrTEW0B8/qCjQc="; | ||
| name = "${pname}-${version}-source"; |
There was a problem hiding this comment.
I just tried it locally and that does not change the hash which is really surprising to me because I always thought it did. Only the store path changed.
|
|
||
| installPhase = '' | ||
| runHook preInstall | ||
| ls -lah |
There was a problem hiding this comment.
| ls -lah |
| propagatedBuildInputs = [ | ||
| ] ++ lib.optionals (pythonOlder "3.11") [ |
There was a problem hiding this comment.
| propagatedBuildInputs = [ | |
| ] ++ lib.optionals (pythonOlder "3.11") [ | |
| propagatedBuildInputs = lib.optionals (pythonOlder "3.11") [ |
nit
|
I just built up to python310.pkgs.cryptography 👍🏼 |
|
This is all going to change again, not worth building upon currently. Don't bother. |
Why? |
|
Because bootstrap should happen through the But apparently I lack the energy to follow through here. |
|
Superseded by #245509 |
3 participants
As more and more low-level packages are moving towards
flit-core,we need to bootstrap it and other packages to escape infinite recursion
scenarios at the base of our package set.
Next packages like build and installer should be made more lean, so they
can be used in our build and install phase hooks for pyproject based builds.
Taking the chance to also adopt a few core packages to the python team.
The changes already build, but I'm very much open to discussion of how
I solved things.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)