libopenmpt: doCheck only if canExecute#232305
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom May 25, 2023
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
And optional -> optionals style for libpulseaudio
OPNA2608
force-pushed
the
fix/libopenmpt_doCheck
branch
from
52f21da to
3e2f831
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2246 |
1 task
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Noticed for #232304 that this unconditionally enables
doCheck, when it should really only do it ifbuildPlatformcan executehostPlatform.This should hopefully not cause any mass-rebuilds (since
buildPlatform == hostPlatformunless doing cross) and be fine for master as-is.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)