Skip to content

Comments

gnupg: remove systemd user config and bring back 2.4.1#231110

Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
corngood:gpg-systemd
Jun 29, 2023
Merged

gnupg: remove systemd user config and bring back 2.4.1#231110
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
corngood:gpg-systemd

Conversation

@corngood
Copy link
Contributor

@corngood corngood commented May 10, 2023

This was removed upstream in:

gpg/gnupg@eae28f1

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@corngood
Copy link
Contributor Author

corngood commented May 10, 2023

#231108 fixes the systemd user config.

@ofborg ofborg bot requested review from fpletz and vrthra May 10, 2023 17:54
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels May 10, 2023
@SuperSandro2000 SuperSandro2000 requested a review from rnhmjoj May 10, 2023 17:57
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 26, 2023
@corngood corngood changed the title gnupg: remove systemd user config gnupg: remove systemd user config and bring back 2.4.1 Jun 26, 2023
This was referenced Jun 26, 2023
Merged
Merged
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 26, 2023
@github-actions github-actions bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 29, 2023
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jun 29, 2023

I just rebased this PR on staging after the all the merges to make it way smaller and easier to review.

@SuperSandro2000 SuperSandro2000 merged commit e34df65 into NixOS:staging Jun 29, 2023
@corngood corngood deleted the gpg-systemd branch June 29, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@vrthra vrthra Awaiting requested review from vrthra

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corngood @SuperSandro2000 @rnhmjoj