Merged
Conversation
Member
Author
|
And ruby 2 is already EOL a month ago. we may as well drop it, what a bad timing for 23.05. |
ajs124
approved these changes
May 4, 2023
Member
ajs124
left a comment
There was a problem hiding this comment.
yup, looks like a typo
thanks for catching this
Member
|
This broke build of /cc #231026 Around a hundred builds are reported as caused by this, currently. |
Member
Author
|
The patch below seem to fix the build. (The backtrace show that openssl is required by --- a/pkgs/top-level/ruby-packages.nix
+++ b/pkgs/top-level/ruby-packages.nix
@@ -2356,7 +2356,7 @@
version = "2.5.9";
};
nokogiri = {
- dependencies = ["mini_portile2" "racc"];
+ dependencies = ["mini_portile2" "racc" "openssl"];
groups = ["default"];
platforms = [];
source = { |
Member
Author
|
And indeed https://hydra.nixos.org/build/219355113/nixlog/1: |
NickCao
added a commit
to NickCao/nixpkgs
that referenced
this pull request
May 11, 2023
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The logic was introduced in a902277, but still pinned ruby 3.0+ to openssl_1_1 (due to typo?). cc @ajs124
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)