Skip to content

haskellPackages.streamly-lmdb: unbreak#229606

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
shlok:streamly-lmdb-unbreak
May 3, 2023
Merged

haskellPackages.streamly-lmdb: unbreak#229606
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
shlok:streamly-lmdb-unbreak

Conversation

@shlok
Copy link
Contributor

@shlok shlok commented May 3, 2023

Things done
  • Manually modified configuration-nix.nix, configuration-common.nix, and broken.yaml.
  • Tested compilation of all pkgs that depend on this change using nix-build --no-out-link -A haskellPackages.streamly-lmdb --arg config '{ allowBroken = true; }'
  • Ran maintainers/scripts/haskell/regenerate-hackage-packages.sh and included the result in the PR.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 3, 2023
@maralorn
Copy link
Member

maralorn commented May 3, 2023

Thanks!

Huh, I am just realizing that I oversaw something with the previous PR for streamly-archive. Overrides which are permanently required like the pkgs.libarchive and pkgs.lmdb belong into configuration-nix.nix, overrides which are only temporary and concern only the current versions of the package set belong into configuration-common.nix. Can you please split the override into the two files accordingly?

Otherwise, this looks fine.

@shlok
Copy link
Contributor Author

shlok commented May 3, 2023

Sure, we can try again now.

@maralorn
Copy link
Member

maralorn commented May 3, 2023

We don’t do these back-merge-commits in nixpkgs. We already have a huge commit count. Can you please rebase instead?

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 3, 2023
@shlok shlok force-pushed the streamly-lmdb-unbreak branch from fea6253 to a1a4c4d Compare May 3, 2023 14:58
@shlok
Copy link
Contributor Author

shlok commented May 3, 2023

We can try again now; and your patience is appreciated.

@maralorn
Copy link
Member

maralorn commented May 3, 2023

Well, I can be super patient while telling other people what to do.^^

Thanks for fixing everything. The appreciation is mutual.

@maralorn maralorn merged commit f2ef899 into NixOS:haskell-updates May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants