Skip to content

haskellPackages: Add maintainer shlok#229459

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
shlok:patch-1
May 2, 2023
Merged

haskellPackages: Add maintainer shlok#229459
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
shlok:patch-1

Conversation

@shlok
Copy link
Contributor

@shlok shlok commented May 2, 2023

No description provided.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 2, 2023
@shlok shlok mentioned this pull request May 2, 2023
Merged
2 tasks
@cdepillabout
Copy link
Member

cdepillabout commented May 2, 2023

Thanks!

@cdepillabout cdepillabout merged commit 394d6a8 into NixOS:haskell-updates May 2, 2023
sternenseemann added a commit that referenced this pull request May 3, 2023
@sternenseemann
Revert "haskellPackages: Add maintainer shlok"
a6bb2cc 
This reverts commit ad38216 and
regenerates hackage-packages.nix.

Reason for Revert: There is no lib.maintainers.shlok.

Reference #229459.
@sternenseemann
Copy link
Member

sternenseemann commented May 3, 2023

I've reverted this PR in a6bb2cc. Maintainers need a corresponding entry in maintainers/maintainer-list.nix before they can take over maintainership of any package. Please re-create this PR which also adds such an entry.

@cdepillabout
Copy link
Member

cdepillabout commented May 3, 2023

@sternenseemann Ah, good catch! Sorry for that.

@shlok
Copy link
Contributor Author

shlok commented May 3, 2023

@sternenseemann Thanks for the feedback. Here is the new PR: #229647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

1 more reviewer

@lucasew lucasew lucasew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shlok @cdepillabout @sternenseemann @lucasew