Skip to content

gdb: enable debuginfod support only on platforms with elfutils support#228697

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:gdb-and-elfutils
Apr 28, 2023
Merged

gdb: enable debuginfod support only on platforms with elfutils support#228697
trofi merged 1 commit intoNixOS:masterfrom
trofi:gdb-and-elfutils

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 28, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi trofi mentioned this pull request Apr 28, 2023
12 tasks
@trofi trofi requested a review from IvarWithoutBones April 28, 2023 09:11
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works perfectly for me, thanks for the swift response and fix!

Result of nixpkgs-review pr 228697 run on x86_64-darwin 1

6 packages marked as broken and skipped:
  • cargo-valgrind
  • gef
  • libinsane
  • plm
  • trealla
  • valgrind
4 packages failed to build:
  • nimPackages.bumpy
  • nimPackages.eris
  • nimPackages.pixie
  • nimPackages.vmath
52 packages built:
  • dmd
  • gdb
  • gdbHostCpuOnly
  • gdbgui
  • nim (nimPackages.nim)
  • nimPackages.asciigraph
  • nimPackages.asynctools
  • nimPackages.base32
  • nimPackages.base45
  • nimPackages.c2nim
  • nimPackages.cbor
  • nimPackages.chroma
  • nimPackages.coap
  • nimPackages.flatty
  • nimPackages.freedesktop_org
  • nimPackages.getdns
  • nimPackages.hts-nim
  • nimPackages.illwill
  • nimPackages.illwillwidgets
  • nimPackages.jsonschema
  • nimPackages.jsony
  • nimPackages.nimSHA2
  • nimPackages.nim_builder
  • nimPackages.nimraylib-now
  • nimPackages.nimsimd
  • nimPackages.npeg
  • nimPackages.parsetoml
  • nimPackages.preserves
  • nimPackages.rocksdb
  • nimPackages.safeset
  • nimPackages.sass
  • nimPackages.snappy
  • nimPackages.spry
  • nimPackages.spryvm
  • nimPackages.stew
  • nimPackages.syndicate
  • nimPackages.taps
  • nimPackages.tempfile
  • nimPackages.tkrzw
  • nimPackages.ui
  • nimPackages.x11
  • nimPackages.zippy
  • nimdow
  • nimlsp
  • nimmm
  • nitter
  • nrpl
  • promexplorer
  • pwndbg
  • tinygo
  • tridactyl-native
  • vimPlugins.fruzzy

@ofborg ofborg bot requested review from globin, lsix and nbp April 28, 2023 10:54
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 28, 2023
@trofi trofi merged commit 3b2220d into NixOS:master Apr 28, 2023
@trofi trofi deleted the gdb-and-elfutils branch April 28, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants