gcc: fix fastStdenv breakage from #209870 #228606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently gcc has these `Makefile` targets: - `""` - `"bootstrap"` - `"profiledbootstrap"` ... but no `"profiled"`. So if you want a profiled compiler, at the moment, it should be bootstrapped. If we ever decide to make the nixpkgs bootstrap use a profiled compiler (which at the moment means nondeterminism) a Nix-driven profile loop is certainly possible, but would take some work. Closes #228597.
ofborg
bot
added
10.rebuild-darwin: 0
ghost
marked this pull request as ready for review
Member
|
It's simple, looks OK and builds, so let's not wait for deeper review(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Apparently gcc has these
Makefiletargets:"""bootstrap""profiledbootstrap"... but no
"profiled". So if you want a profiled compiler, at the moment, it should be bootstrapped.If we ever decide to make the nixpkgs bootstrap use a profiled compiler (which at the moment means nondeterminism) a Nix-driven profile loop is certainly possible, but would take some work.
Closes #228597.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)