Skip to content

gccgo: fix build #228473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wegank merged 1 commit into from
Apr 27, 2023
Merged

gccgo: fix build #228473

wegank merged 1 commit into from
Apr 27, 2023

Conversation

@wegank
Copy link
Member

@wegank wegank commented Apr 27, 2023 •
edited
Loading

Description of changes

Yet another hacky fix.

#209870 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank wegank requested a review from matthewbauer as a code owner April 27, 2023 07:53
@wegank
Copy link
Member Author

wegank commented Apr 27, 2023

@ofborg build gccgo12

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 27, 2023
@wegank wegank changed the title dontmerge: gccgo: fix build gccgo: fix build Apr 27, 2023
@wegank wegank requested a review from trofi April 27, 2023 08:43
@wegank wegank merged commit d27f79a into NixOS:master Apr 27, 2023
@wegank wegank deleted the gccgo-fix branch April 27, 2023 08:51
ghost
ghost reviewed Apr 27, 2023
View reviewed changes
@ghost ghost mentioned this pull request Apr 27, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@trofi trofi Awaiting requested review from trofi

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wegank