nixos/tests/netboot: repair testing by RaitoBezarius · Pull Request #228346 · NixOS/nixpkgs

RaitoBezarius · 2023-04-26T16:27:13Z

Description of changes

This repairs netboot testing, performs some cleanup to move to modern QEMU test infrastructure.

Depends on #228047.

Things done

nixos/tests/boot.nix

nikstur · 2023-04-26T21:13:09Z

Very cool. Misleading title though. Repairing netboot testing is just a side effect of the change :D

RaitoBezarius · 2023-04-26T21:18:45Z

Very cool. Misleading title though. Repairing netboot testing is just a side effect of the change :D

heh, I take any suggestions :)

It's still WIP because I have some semantic issues with the solutions.

nixos/tests/boot.nix

alyssais · 2023-04-27T21:43:08Z

Testing with the second to last commit as instructed, my VM is still being created with a block device where AIUI there shouldn't be one:

nixosTest {
  name = "test";
  nodes.machine = {
    imports = [ nixos/modules/installer/netboot/netboot-minimal.nix ];
    virtualisation.diskImage = null;
    virtualisation.useNixStoreImage = true;
    virtualisation.mountHostNixStore = false;
  };
  testScript = "machine.fail('stat /dev/vda')"; 
}

It looks like fileSystems still ends up with /nix/store being mounted from /dev/vda.

nixos/modules/installer/netboot/netboot.nix

nikstur · 2023-06-21T20:58:53Z

Can you rebase this?

nikstur · 2023-06-22T14:44:02Z

It seems like neither nixosTests.biosNetboot nor nixosTests.uefiNetboot is actually broken. Neither in 23.05 nor on master. Is this just a refactor then? Or am I missing something?

RaitoBezarius · 2023-06-22T19:48:45Z

You're right, this deserves more investigation.

nikstur · 2023-07-03T22:33:13Z

@alyssais do you have some more insight on what is currently broken for netbooting?

alyssais · 2023-11-06T10:39:27Z

It's not that netboot tests are broken, it's that directBoot is broken, as you'll see if you try to run the directBoot test from this PR without the first commit. The NixOS netboto tests don't use directBoot, so they're still working.

nixos/modules/installer/netboot/netboot.nix

RaitoBezarius · 2024-01-25T01:39:01Z

So really: 8321fc6 (#228346) is a commit that should be three:

modernize the boot test
force link the channel or fail at boot
enable fine-grained override of each filesystem if they are not completely swapped <- this one, @nikstur, is the one I guess we need to discuss.

Next commits, AFAIK, are pretty much uncontroversial, right?

nikstur · 2024-01-26T15:43:55Z

enable fine-grained override of each filesystem if they are not completely swapped

This one shouldn't be required anymore since you can set virtualisation.fileSystems = lib.mkForce { } now.

RaitoBezarius · 2024-01-26T15:51:49Z

enable fine-grained override of each filesystem if they are not completely swapped

This one shouldn't be required anymore since you can set virtualisation.fileSystems = lib.mkForce { } now.

How does that work when you want to keep the virtualization filesystems, and you want to override yours? (remember: my usecase is a bit different from yours :P — I need the intelligence of qemu-vm.nix and the netboot mechanism)

Sometimes, you would like to inherit from the VM framework and your user code because you know better than the VM framework rather than replacing wholesale the fileSystems module. This came up for netboot testing needs.

This verifies that we can direct boot a netboot image as expected.

…hardcoding `initrd`, disable compression for initrd

RaitoBezarius · 2024-02-11T16:58:39Z

PTAL @nikstur. I moved the irrelevant stuff and fixed the direct boot test again.

nikstur

The description of the PR doesn't really fit anymore. You're not really reparing anything and also not cleaning up the old infrastructure. Instead you're adding a new direct boot test (which I still think is worthwhile).

nikstur · 2024-02-16T23:54:02Z

nixos/modules/installer/netboot/netboot.nix


+    # We only want to set those options in the context of
+    # the QEMU infrastructure.
+    virtualisation = lib.optionalAttrs (options ? virtualisation.directBoot) {


I don't really understand why we need to set this here. If this needs to be re-usable between tests it should be a fixure in tests/common IMO

nikstur · 2024-02-16T23:58:05Z

nixos/modules/virtualisation/qemu-vm.nix

    # filesystems don't necessarily exist in the VM). You can disable this
    # override by setting `virtualisation.fileSystems = lib.mkForce { };`.
-    fileSystems = lib.mkIf (cfg.fileSystems != { }) (mkVMOverride cfg.fileSystems);
+    fileSystems = lib.mkIf (cfg.fileSystems != { }) (lib.mapAttrs (n: v: mkVMOverride v) cfg.fileSystems);


Not sure if we really need this. You could just set virtualisation.fileSystems to { } to use just the ones defined in netboot.nix. Is there actually a good reason to mix the ones defined by qemu-vm.nix and netboot.nix?

nikstur · 2024-02-17T00:01:46Z

nixos/tests/boot.nix

+        imports = [ ../modules/installer/netboot/netboot-minimal.nix ];
+        virtualisation.memorySize = 4096;
+      };
+      testScript = "machine.fail('stat /dev/vda')";


We can probably do better than this. What about checking whether the nix store is mounted via a loop device? That's more of a key characteristic of netboot for me.

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 26, 2023

RaitoBezarius requested review from alyssais, nikstur and roberth April 26, 2023 16:27

RaitoBezarius commented Apr 26, 2023

View reviewed changes

nixos/tests/boot.nix Outdated Show resolved Hide resolved

ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 26, 2023

RaitoBezarius force-pushed the netboot-tests branch 2 times, most recently from 81e7333 to 102bc20 Compare April 26, 2023 19:26

RaitoBezarius force-pushed the netboot-tests branch from 102bc20 to c292c54 Compare April 26, 2023 21:18

alyssais reviewed Apr 26, 2023

View reviewed changes

nixos/tests/boot.nix Outdated Show resolved Hide resolved

alyssais mentioned this pull request Apr 28, 2023

How to use custom filesystems inside a virtual machine with bootloader? #228572

Open

RaitoBezarius force-pushed the netboot-tests branch 4 times, most recently from bda04d7 to e765786 Compare April 28, 2023 20:27

alyssais reviewed Apr 30, 2023

View reviewed changes

nixos/modules/installer/netboot/netboot.nix Outdated Show resolved Hide resolved

RaitoBezarius force-pushed the netboot-tests branch from e765786 to b2625a7 Compare May 5, 2023 13:43

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels May 5, 2023

RaitoBezarius force-pushed the netboot-tests branch from b2625a7 to 2499de7 Compare May 5, 2023 14:15

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 5, 2023

RaitoBezarius force-pushed the netboot-tests branch 2 times, most recently from 9e37f60 to c71fbaa Compare May 5, 2023 16:14

RaitoBezarius mentioned this pull request May 25, 2023

nixos/qemu-vm: introduce virtualisation.directBoot #234034

Merged

12 tasks

RaitoBezarius force-pushed the netboot-tests branch from c71fbaa to 74064b6 Compare June 22, 2023 13:05

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 22, 2023

alyssais added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 6, 2023

alyssais reviewed Nov 21, 2023

View reviewed changes

nixos/modules/installer/netboot/netboot.nix Outdated Show resolved Hide resolved

RaitoBezarius force-pushed the netboot-tests branch 2 times, most recently from ff45b56 to e971b6b Compare January 25, 2024 01:36

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 25, 2024

RaitoBezarius added 3 commits February 11, 2024 16:32

nixos/virtualisation/qemu-vm: deep merge fileSystems

5c0bc72

Sometimes, you would like to inherit from the VM framework and your user code because you know better than the VM framework rather than replacing wholesale the fileSystems module. This came up for netboot testing needs.

nixos/tests/netboot: add directBoot test

fd110f5

This verifies that we can direct boot a netboot image as expected.

nixos/netboot: use config.system.boot.loader.initrdFile instead of …

95582ad

…hardcoding `initrd`, disable compression for initrd

RaitoBezarius force-pushed the netboot-tests branch from e971b6b to 95582ad Compare February 11, 2024 16:58

RaitoBezarius marked this pull request as ready for review February 11, 2024 16:58

nikstur reviewed Feb 17, 2024

View reviewed changes

wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025

Uh oh!

Conversation

RaitoBezarius commented Apr 26, 2023

Description of changes

Things done

Uh oh!

Uh oh!

nikstur commented Apr 26, 2023

Uh oh!

RaitoBezarius commented Apr 26, 2023

Uh oh!

Uh oh!

alyssais commented Apr 27, 2023

Uh oh!

Uh oh!

nikstur commented Jun 21, 2023

Uh oh!

nikstur commented Jun 22, 2023

Uh oh!

RaitoBezarius commented Jun 22, 2023

Uh oh!

nikstur commented Jul 3, 2023

Uh oh!

alyssais commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

RaitoBezarius commented Jan 25, 2024

Uh oh!

nikstur commented Jan 26, 2024

Uh oh!

RaitoBezarius commented Jan 26, 2024

Uh oh!

RaitoBezarius commented Feb 11, 2024

Uh oh!

nikstur left a comment

Choose a reason for hiding this comment

Uh oh!

nikstur Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

nikstur Feb 16, 2024

Choose a reason for hiding this comment

Uh oh!

nikstur Feb 17, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alyssais commented Nov 6, 2023 •

edited

Loading