haskell.packages.ghc961.{aeson,singleton-bool,unliftio-core,lukko,lucid}: Remove unnecessary jailbreaks#227871
Merged
maralorn merged 2 commits intoNixOS:haskell-updatesfrom Apr 23, 2023
ysangkok:janus/remove-jailbreaks
Merged
haskell.packages.ghc961.{aeson,singleton-bool,unliftio-core,lukko,lucid}: Remove unnecessary jailbreaks#227871maralorn merged 2 commits intoNixOS:haskell-updatesfrom ysangkok:janus/remove-jailbreaks
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
ysangkok:janus/remove-jailbreaks
Conversation
ysangkok
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
…id}: Remove unnecessary jailbreaks
ysangkok
changed the title
Member
|
@ofborg build haskell.packages.ghc961.aeson haskell.packages.ghc961.singleton-bool haskell.packages.ghc961.unliftio-core haskell.packages.ghc961.lucid haskell.packages.ghc961.lukko |
maralorn
requested changes
Apr 23, 2023
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
@ofborg build haskell.packages.ghc961.aeson haskell.packages.ghc961.singleton-bool haskell.packages.ghc961.unliftio-core haskell.packages.ghc961.lucid haskell.packages.ghc961.lukko |
Member
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
These jailbreaks are not necessary, let's remove them such that they don't clutter the code.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)