Skip to content

polyphone: drop redundant INCLUDEPATH to libjack2#227866

Merged
trofi merged 1 commit intoNixOS:stagingfrom
trofi:polyphone-no-override
Apr 27, 2023
Merged

polyphone: drop redundant INCLUDEPATH to libjack2#227866
trofi merged 1 commit intoNixOS:stagingfrom
trofi:polyphone-no-override

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 23, 2023

diffoscope shows no difference before and after the change.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

`diffoscope` shows no difference before and after the change.
@ofborg ofborg bot requested a review from Maxdamantus April 23, 2023 21:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 23, 2023
@trofi trofi merged commit 6ab9a85 into NixOS:staging Apr 27, 2023
@trofi trofi deleted the polyphone-no-override branch April 27, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant