Skip to content

timidity: drop unused NIX_LDFLAGS override#227789

Merged
vcunat merged 1 commit intoNixOS:stagingfrom
trofi:timidity-no-LDFLAGS
Apr 26, 2023
Merged

timidity: drop unused NIX_LDFLAGS override#227789
vcunat merged 1 commit intoNixOS:stagingfrom
trofi:timidity-no-LDFLAGS

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 23, 2023

jack2 detection should Just Work. diffoscope shows no difference for this change.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

`jack2` detection should Just Work. `diffoscope` shows no difference
for this change.
@ofborg ofborg bot requested a review from MarcWeber April 23, 2023 13:07
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 23, 2023
@vcunat vcunat merged commit f2198ad into NixOS:staging Apr 26, 2023
@trofi trofi deleted the timidity-no-LDFLAGS branch April 26, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants