Skip to content

python310Packages.pyasn1-modules: 0.2.8 -> 0.3.0, python310Packages.pyasn1: 0.4.8 -> 0.5.0#227630

Merged
fabaff merged 2 commits intoNixOS:stagingfrom
fabaff:pyasn1-bump
May 5, 2023
Merged

python310Packages.pyasn1-modules: 0.2.8 -> 0.3.0, python310Packages.pyasn1: 0.4.8 -> 0.5.0#227630
fabaff merged 2 commits intoNixOS:stagingfrom
fabaff:pyasn1-bump

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Apr 22, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 22, 2023
@fabaff
Copy link
Member Author

fabaff commented Apr 22, 2023

Result of nixpkgs-review pr 227630 run on x86_64-linux 1

@ofborg ofborg bot requested a review from SuperSandro2000 April 22, 2023 16:26
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 22, 2023
SuperSandro2000
SuperSandro2000 reviewed Apr 23, 2023
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Apr 23, 2023
View reviewed changes
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 23, 2023

We don't need to split the commits that much, three would already be enough IMO

@ofborg ofborg bot requested a review from SuperSandro2000 April 30, 2023 15:17
@fabaff
Copy link
Member Author

fabaff commented Apr 30, 2023

Needs to go to staging...

@fabaff fabaff marked this pull request as draft May 3, 2023 22:42
@fabaff fabaff changed the base branch from master to staging May 3, 2023 22:43
@fabaff fabaff marked this pull request as ready for review May 3, 2023 22:43
@SuperSandro2000 SuperSandro2000 requested a review from mweinelt May 5, 2023 19:46
@fabaff fabaff merged commit db90c55 into NixOS:staging May 5, 2023
@fabaff fabaff deleted the pyasn1-bump branch May 5, 2023 20:30
@vcunat
Copy link
Member

vcunat commented May 10, 2023 •
edited
Loading

This broke tests of python3*Packages.twisted, and through that hundreds of other builds.

Note that we are (and were) in period where "breaking changes" are disallowed. Though with python packages it's often hard to tell in advance, I suppose. GitHub tag calls it a "major release", so maybe it's not suitable for 23.05 anymore? But I guess it might be OK to keep, if someone fixes the regressions quickly, etc.

/cc #231026

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 11, 2023

#231253

@mweinelt
Copy link
Member

mweinelt commented May 14, 2023

Also broke certipy.

https://hydra.nixos.org/build/219691949

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 14, 2023

#231903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabaff @SuperSandro2000 @vcunat @mweinelt