Haskell updates maintainer#227427
Conversation
|
Github wants to pull-request this into master, but I have branched from haskell-updates. |
|
Well, that’s a lot of packages.^^ But I see you maintain all of them on hackage, so we are very happy for you to take ownership for them here, too. Cool. A couple of points:
|
67b7e4e to
5d91d02
Compare
|
Thank you! |
| thielema = { | ||
| name = "Henning Thielemann"; | ||
| email = "nix@henning-thielemann.de"; | ||
| github = "thielema"; | ||
| githubId = 898989; | ||
| }; |
There was a problem hiding this comment.
@thielema it looks like you are not part of the @NixOS/nixpkgs-maintainers team, you likely missed the invite when you became maintainer / the team was created. This means you can't be requested for review properly. Please consider requesting another invite, see https://github.com/NixOS/nixpkgs/tree/master/maintainers#tools-for-maintainers for how to do that.
|
On Thu, 6 Nov 2025, Wolfgang Walther wrote:
@wolfgangwalther commented on this pull request.
______________________________________________________________________________________________________________________
In maintainers/maintainer-list.nix:
> + thielema = {
+ name = "Henning Thielemann";
+ email = ***@***.***";
+ github = "thielema";
+ githubId = 898989;
+ };
@thielema it looks like you are not part of the @NixOS/nixpkgs-maintainers team, you likely missed the invite when you
became maintainer / the team was created. This means you can't be requested for review properly. Please consider
requesting another invite, see https://github.com/NixOS/nixpkgs/tree/master/maintainers#tools-for-maintainers for how
to do that.
I rebased my commits from April 2023 and created a new pull-request
against haskell-updates. Would this trigger a new invitation?
|
Your commits were merged already, there is no point in doing that again. Please read the link I posted earlier, it explains how to get an invite to the team. |
|
On Thu, 6 Nov 2025, Wolfgang Walther wrote:
[9132420?s=20&v=4] wolfgangwalther left a comment (NixOS/nixpkgs#227427)
I rebased my commits from April 2023 and created a new pull-request against haskell-updates. Would this
trigger a new invitation?
Your commits were merged already, there is no point in doing that again.
Please read the link I posted earlier, it explains how to get an invite
to the team.
That's what I did. It reads:
"How to become a maintainer
...
In order to do so, add yourself to the maintainer-list.nix, and then to
the desired package's meta.maintainers list, and send a PR with the
changes."
That's done. Then the doc continues:
"Tools for maintainers
...
New maintainers will automatically get invited to join the
NixOS/nixpkgs-maintainers GitHub team. By joining, you will get some
triaging rights in the nixpkgs repository, like the ability to close and
reopen issues made by others, and managing labels. However, the GitHub
team invite is usually only sent by email, and is only valid for one week!
Should it expire, please ask for a re-invite in the GitHub org owners help
desk Matrix channel."
I have no access to Matrix. How can I retrigger the invitation? Could you
do this for me?
I guess I cannot simply remove myself as maintainer and re-add, because
there are already packages maintained by me.
|
@NixOS/org can someone invite @thielema again? |
Description of changes
add thielema as maintainer to configuration-hackage2nix/main.yaml