Skip to content

Haskell updates maintainer#227427

Merged
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
thielema:haskell-updates-maintainer
Apr 21, 2023
Merged

Haskell updates maintainer#227427
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
thielema:haskell-updates-maintainer

Conversation

@thielema
Copy link
Contributor

Description of changes

add thielema as maintainer to configuration-hackage2nix/main.yaml

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 21, 2023
@thielema thielema closed this Apr 21, 2023
@thielema
Copy link
Contributor Author

Github wants to pull-request this into master, but I have branched from haskell-updates.

@thielema thielema reopened this Apr 21, 2023
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 21, 2023
@wegank wegank changed the base branch from master to haskell-updates April 21, 2023 11:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 21, 2023
@maralorn
Copy link
Member

Well, that’s a lot of packages.^^ But I see you maintain all of them on hackage, so we are very happy for you to take ownership for them here, too. Cool.

A couple of points:

  1. A while back, I wrote down this information about fixing packages and being a maintainer. https://md.darmstadt.ccc.de/haskell-packages-contribution-checklist#What-does-it-mean-to-be-a-maintainer-of-a-Haskell-package Maybe have a look at that.
  2. If a package you maintain is broken by a dependency of it, you will get notified either way, even if you are not a maintainer of a broken dependency. You might consider only becoming a maintainer of some of the packages. But in your case, that doesn’t seem to make a lot of sense.
  3. To conform more to the contributor's guide, your commit message should start with a scope. e.g. haskellPackages: …
  4. You need an entry in maintainers/maintainer-list.nix.
  5. We, or rather our tooling, only notifies maintainers when packages break. So if you want to confirm that they all work, you will need to check that manually. One idea in this case, with which I would be okay, would be to simply throw them all out of the broken.yaml, merge, let hydra create the report and see how much breakage is happening.

@maralorn maralorn force-pushed the haskell-updates-maintainer branch from 67b7e4e to 5d91d02 Compare April 21, 2023 20:27
@maralorn
Copy link
Member

Thank you!

@maralorn maralorn merged commit 1cc403f into NixOS:haskell-updates Apr 21, 2023
Comment on lines +15413 to +15418
thielema = {
name = "Henning Thielemann";
email = "nix@henning-thielemann.de";
github = "thielema";
githubId = 898989;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thielema it looks like you are not part of the @NixOS/nixpkgs-maintainers team, you likely missed the invite when you became maintainer / the team was created. This means you can't be requested for review properly. Please consider requesting another invite, see https://github.com/NixOS/nixpkgs/tree/master/maintainers#tools-for-maintainers for how to do that.

@thielema
Copy link
Contributor Author

thielema commented Nov 6, 2025 via email

@wolfgangwalther
Copy link
Contributor

I rebased my commits from April 2023 and created a new pull-request against haskell-updates. Would this trigger a new invitation?

Your commits were merged already, there is no point in doing that again. Please read the link I posted earlier, it explains how to get an invite to the team.

@thielema
Copy link
Contributor Author

thielema commented Nov 6, 2025 via email

@wolfgangwalther
Copy link
Contributor

I have no access to Matrix. How can I retrigger the invitation? Could you do this for me?

@NixOS/org can someone invite @thielema again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants