Skip to content

Comments

autoflake: depend on tomli for older pythons#227423

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
moduon:autoflake-tomli
Jun 8, 2023
Merged

autoflake: depend on tomli for older pythons#227423
mweinelt merged 1 commit intoNixOS:stagingfrom
moduon:autoflake-tomli

Conversation

@yajo
Copy link
Contributor

@yajo yajo commented Apr 21, 2023 •
edited
Loading

Description of changes

As you can see in PyCQA/autoflake#138, TOML support is added using python 3.11's builtin tomllib. However, for older Python versions, they use tomli. Thus, it must be included for those versions.

@moduon MT-2798

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@yuriaisaka

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 21, 2023
@natsukium
Copy link
Member

natsukium commented Apr 21, 2023

This PR causes 1000+ rebuilds, you must send the PR to staging instead of the master branch.
and python3Packages.autoflake is appropriate for the commit message and the PR title.

@yajo yajo changed the base branch from master to staging April 24, 2023 09:14
@yajo yajo force-pushed the autoflake-tomli branch from 7200445 to c33da58 Compare April 24, 2023 09:14
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 24, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 24, 2023
@yajo yajo force-pushed the autoflake-tomli branch from c33da58 to cd01c05 Compare April 24, 2023 09:24
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 24, 2023
@yajo
Copy link
Contributor Author

yajo commented Apr 24, 2023

Thanks for the review, it's all attended.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 24, 2023
@yajo
python3Packages.autoflake: depend on tomli for older pythons
09dd617 
As you can see in PyCQA/autoflake#138, TOML support is added using python 3.11's builtin `tomllib`. However, for older Python versions, they use `tomli`. Thus, it must be included for those versions.

@moduon MT-2798
@yajo yajo force-pushed the autoflake-tomli branch from cd01c05 to 09dd617 Compare April 24, 2023 12:26
@yajo
Copy link
Contributor Author

yajo commented Apr 26, 2023

Hello! This one should be ready to merge. Could you please give it another review? Thanks!

@natsukium
Copy link
Member

natsukium commented May 1, 2023 •
edited
Loading

@mweinelt @fabaff @yuriaisaka
Would you please check this PR?
It seems to be a fine patch.

@natsukium natsukium requested review from fabaff and mweinelt May 1, 2023 01:47
@yajo
Copy link
Contributor Author

yajo commented Jun 8, 2023

Ping! This one is simple and obvious IMHO. Could it be merged please?

@mweinelt mweinelt merged commit f8b7dd4 into NixOS:staging Jun 8, 2023
@yajo yajo deleted the autoflake-tomli branch June 8, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@fabaff fabaff Awaiting requested review from fabaff

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yajo @natsukium @mweinelt