Skip to content

haskellPackages fourmolu 0.10.0.0 -> 0.10.1.0#226836

Merged
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
tmcl:fourmolu-0_10_1_0
Apr 18, 2023
Merged

haskellPackages fourmolu 0.10.0.0 -> 0.10.1.0#226836
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
tmcl:fourmolu-0_10_1_0

Conversation

@tmcl
Copy link
Contributor

@tmcl tmcl commented Apr 18, 2023

Description of changes

Upgrade fourmolu-0.10.0.0 -> fourmolu-0.10.1.0 (in haskell packages). This was a bugfix release for fourmolu https://github.com/fourmolu/fourmolu/releases/tag/v0.10.1.0 that was previously in nixpkgs but got removed during an upgrade of hackage and a fix for haskell-language-server.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Apr 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 18, 2023
@cdepillabout
Copy link
Member

Thanks!

Would you be able to rebase this on the haskell-updates branch? And also check that all the expected HLSes still compile? (I just want to make sure that changing this version doesn't break HLS)

@tmcl tmcl force-pushed the fourmolu-0_10_1_0 branch from 8618f88 to 0fd4b54 Compare April 18, 2023 12:41
@tmcl tmcl requested review from jtojnar and piegamesde as code owners April 18, 2023 12:41
@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 18, 2023
@tmcl
Copy link
Contributor Author

tmcl commented Apr 18, 2023

Thanks @cdepillabout. I have rebased it but I hope I haven't accidentally pinged the wrong people by doing it.

I can confirm that haskell.packages.ghc944.haskell-language-server and haskell.packages.ghc92.haskell-language-server successfully built with this change before I rebased. But post rebase I'm getting a spurious error 'error: Check if 'bad bounds' was resolved in lucid 2.11.20230408 and update or remove this' and a requirement to rebuild GHC, I don't know if there's any cache available?

@maralorn
Copy link
Member

@tmcl Sorry, that I dropped the bugfix.

The rebase doesn’t look right. You rebased some stuff from master which currently isn’t in haskell-updates onto haskell-updates. Can you put this PR into draft mode, change the base to go to haskell-updates and fix your branch?

I wouldn’t worry about hls too much. Let’s merge this into haskell-updates and wait for hydra to confirm that it works. I don’t expect this minor update to be an issue.

@tmcl tmcl marked this pull request as draft April 18, 2023 12:58
Tristan McLeay added 2 commits April 18, 2023 14:59
Restore bugfix release previously part of nixpkgs.
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
@tmcl tmcl force-pushed the fourmolu-0_10_1_0 branch from 0fd4b54 to 7bf6c54 Compare April 18, 2023 13:00
@github-actions github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 18, 2023
@tmcl tmcl changed the base branch from master to haskell-updates April 18, 2023 13:01
@tmcl
Copy link
Contributor Author

tmcl commented Apr 18, 2023

No worries @maralorn

There we go, fixed the base.

@tmcl tmcl marked this pull request as ready for review April 18, 2023 13:03
@maralorn
Copy link
Member

Excellent!

@maralorn maralorn merged commit 42567fe into NixOS:haskell-updates Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants