Add two missing ocamlPackages.cohttp-* packages#226662
Merged
ulrikstrid merged 2 commits intoNixOS:masterfrom Apr 19, 2023
Merged
Add two missing ocamlPackages.cohttp-* packages#226662ulrikstrid merged 2 commits intoNixOS:masterfrom
ocamlPackages.cohttp-* packages#226662ulrikstrid merged 2 commits intoNixOS:masterfrom
Conversation
Contributor
|
Result of 4 packages built:
|
Alizter
approved these changes
Apr 18, 2023
Member
|
If you rebase on master we should be able to merge this |
f99d115 to
d0b92d9
Compare
Contributor
Author
|
Done. Both packages build fine for me on |
ulrikstrid
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As of 5.1.0, cohttp contains two packages that are not in nixpkgs, namely
cohttp-lwt-jsooandcohttp-top. This PR adds the two packages in question. Three notes:This PR builds on top of ocamlPackages.cohttp*: 5.0.0 -> 5.1.0 #226657. Changes to
pkgs/development/ocaml-modules/cohttp/default.nixshould therefore be discussed there instead. I did this to avoid a situation where (a) we test bumping the version on one hand and (b) we test adding the two packages on the other hand, but we don't (c) test adding the two packages with the bumped version, where (a) and (b) would be fine but (c) wouldn't. The two packages in question already exist in version 5.0.0 of cohttp, though, so if my reasoning isn't the best I could also make this PR independent.By inheriting metadata from
cohttpandcohttp-lwt, I am effectively making you, @vbgl, maintainer of these two new packages. I thought it was odd for me to put myself as maintainer of these two when you were already handling the rest, but this solution is also a bit odd. WDYT?The current
masterbranch ofcohttpincludes yet another set of new packages that will probably land in cohttp 6.0.0, namely:cohttp-benchcohttp-curlcohttp-curl-asynccohttp-curl-lwtcohttp-eiocohttp-server-lwt-unixhttpThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)