Skip to content

Comments

beautifulsoup4: fix cross#226121

Merged
Artturin merged 1 commit intomasterfrom
unknown repository
Apr 24, 2023
Merged

beautifulsoup4: fix cross#226121
Artturin merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Apr 14, 2023 •
edited by ghost
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Apr 14, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 14, 2023
@ofborg ofborg bot requested a review from domenkozar April 14, 2023 07:27
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 14, 2023
@lucasew

This comment was marked as resolved.

Sign in to view
Artturin
Artturin reviewed Apr 14, 2023
View reviewed changes
pkgs/development/python-modules/beautifulsoup4/default.nix Outdated
Copy link
Member

@Artturin Artturin Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hook splicing got broken in #194205

Copy link
Author

@ghost ghost Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

Copy link
Member

@Artturin Artturin Apr 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can still merge this but with a comment or a mention in the commit msg to 24dd69b

oh i already did add that

@ghost ghost closed this Apr 24, 2023
@Artturin Artturin reopened this Apr 24, 2023
@Artturin Artturin changed the base branch from master to staging April 24, 2023 10:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 24, 2023
@Artturin Artturin changed the base branch from staging to master April 24, 2023 13:32
@Artturin Artturin merged commit f3fdd1c into NixOS:master Apr 24, 2023
@ghost ghost deleted the pr/fixcross/beautifulsoup4 branch May 5, 2023 05:50
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucasew @Artturin