top-level: Hack around Nix's --arg logic not handling unnamed params#22592
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 9, 2017
Merged
top-level: Hack around Nix's --arg logic not handling unnamed params#22592Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra and @nbp to be potential reviewers. |
Ericson2314
referenced
this pull request
Feb 9, 2017
This is instead of both system and platform, which is kind of ugly.
20c334f to
d680f54
Compare
globin
approved these changes
Feb 9, 2017
Member
|
Having separate |
Member
Author
|
@edolstra that's the way it was before; it's just here for backwards compat. #22575 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
8cd4c31#commitcomment-20815520
Things done
nix-instantiatelocally.