Skip to content

top-level: Hack around Nix's --arg logic not handling unnamed params#22592

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:localSystem-fix
Feb 9, 2017
Merged

top-level: Hack around Nix's --arg logic not handling unnamed params#22592
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:localSystem-fix

Conversation

@Ericson2314
Copy link
Member

Motivation for this change

8cd4c31#commitcomment-20815520

Things done

nix-instantiate locally.

@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra and @nbp to be potential reviewers.

Ericson2314 referenced this pull request Feb 9, 2017
This is instead of both system and platform, which is kind of ugly.
@edolstra
Copy link
Member

edolstra commented Feb 9, 2017

Having separate system and platform arguments is very confusing. What's the difference?

@Ericson2314
Copy link
Member Author

Ericson2314 commented Feb 9, 2017

@edolstra that's the way it was before; it's just here for backwards compat. #22575 (comment)

@Ericson2314 Ericson2314 merged commit 18da9bc into NixOS:master Feb 9, 2017
@Ericson2314 Ericson2314 deleted the localSystem-fix branch February 9, 2017 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants