Conversation
ofborg
bot
added
11.by: package-maintainer
stephank
force-pushed
the
feat/swift58
branch
3 times, most recently
from
0882cc7 to
0897f27
Compare
stephank
force-pushed
the
feat/swift58
branch
3 times, most recently
from
b1fe5cd to
eea3fae
Compare
stephank
force-pushed
the
feat/swift58
branch
3 times, most recently
from
4610421 to
1acf855
Compare
RaitoBezarius
approved these changes
Apr 23, 2023
Member
RaitoBezarius
left a comment
RaitoBezarius
left a comment
There was a problem hiding this comment.
On LLVM changes: sounds good, please apply it to LLVM git too. :)
Member
|
@ofborg build llvmPackages_15.compiler-rt |
Darwin-specific builtins were present on x86-64-darwin, but not on aarch64-darwin. This is the same issue as NixOS#186575, but while the fixes were correctly applied to LLVM 15, we were still disabling the build of builtins on aarch64-darwin. Likely just a confusion.
Contributor
Author
|
I was also able to fix the Linux build, and opened upstream PRs. |
This was referenced Apr 30, 2023
Closed
Contributor
|
Well done ! |
RaitoBezarius
approved these changes
May 3, 2023
Member
RaitoBezarius
left a comment
RaitoBezarius
left a comment
There was a problem hiding this comment.
Nothing changed on the LLVM side. We just merged LLVM16 FWIW.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This also fixes the Linux build.
Result of
nixpkgs-reviewrun on aarch64-darwin 16 packages failed to build:
69 packages built:
The rebuild on Darwin is a little larger primarily because of the compiler-rt fix, but it should be benign.
On x86_64-darwin, I didn't run a full build of all dependents, but
swift,sourcekit-lspandmpvbuild successfully. (The compiler-rt change only affects ARM.)Similarly on x86_64-linux, I only built
swiftandsourcekit-lsp. (The compiler-rt change doesn't affect Linux.)Regarding the failures above:
So it looks like there are no new failures.
Fixes #229280
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)