libplacebo: 4.208.0 -> 5.264.1#224795
Merged
lovesegfault merged 4 commits intoNixOS:masterfrom Apr 6, 2023
Merged
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
I need to package libdovi but it seems to be using |
Member
|
Worth mentioning:
Since it explains the glad2 new dep. And that we can remove the libepoxy dep. |
Member
Author
|
I already got those two sorted. |
github-actions
bot
added
the
6.topic: python
Member
Author
|
@PedroHLC I can't get it to detect glad2 and jinja2 properly, can you help out? |
Member
Their {
postPatch = ''
substituteInPlace meson.build \
--replace 'python_env.append' '#'
'';
}PS: |
Member
Author
|
Result of 46 packages failed to build:
56 packages built:
|
Member
Author
|
libvlc failing. |
Member
Needs to bump, or backport this: https://code.videolan.org/videolan/vlc/-/merge_requests/3027 |
Member
Author
|
Result of 1 package failed to build:
101 packages built:
|
PedroHLC
reviewed
Apr 7, 2023
| # patch to build with recent libplacebo | ||
| (fetchpatch { | ||
| url = "https://code.videolan.org/videolan/vlc/-/merge_requests/3027.patch"; | ||
| hash = "sha256-aV+YT1l0ND/USoIIpxcPhdIlP/06J2FxVW4uArS8j88="; |
Member
There was a problem hiding this comment.
error: hash mismatch in fixed-output derivation '/nix/store/3b1xm0v22yizbr8nkd2p2hnyqg956ngc-3027.patch.drv':
specified: sha256-aV+YT1l0ND/USoIIpxcPhdIlP/06J2FxVW4uArS8j88=
got: sha256-Zz+g75V6X9OZI3sn614K9Uenxl3WtRHKSdLkWP3b17w=
error: 1 dependencies of derivation '/nix/store/mp38cfqhwj1m02a118vhrmh5z5hkfkgk-libvlc-3.0.18.drv' failed to buildDid GitLab change the hash for a merged MR, or did we miscalculate the hash somewhere down the fetchpatch hill?
Member
Author
There was a problem hiding this comment.
Already fixed in another pr.
dotlambda
reviewed
Jul 28, 2023
| @@ -0,0 +1,28 @@ | |||
| { lib | |||
| , python3 | |||
Member
There was a problem hiding this comment.
Not okay in pythonPackages. This would use Python 3.10 for python311Packages.glad2. Fixed in #244135
| jinja2 | ||
| ]; | ||
|
|
||
| pythonImportsCheck = [ "glad" ]; |
Member
There was a problem hiding this comment.
Also add nativeCheckInputs or set doCheck = false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff: https://code.videolan.org/videolan/libplacebo/-/compare/v4.208.0...v5.264.1
Changelog: https://code.videolan.org/videolan/libplacebo/-/tags/v5.264.1
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)