systray-x: init at 0.9.2

[Zahrun]

Description of changes

Closes #212815

The only catch and last mile I didn't figure out is that thunderbird seems to ignore the files in /run/current-system/sw/lib/mozilla. So after installation, I manually did the following commands and could confirm it works properly:

cp /run/current-system/sw/lib/mozilla/native-messaging-hosts/SysTray_X.json ~/.mozilla/native-messaging-hosts
cp /run/current-system/sw/lib/mozilla/thunderbird-addons/extensions/systray-x@Ximi1970.xpi ~/.thunderbird/${myprofile}/extensions/

Any ideas @edolstra @lovesegfault @nbp @vcunat ?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ocfox]

Are you sure this works?

[Zahrun]

Are you sure this works?

As I mention in the PR,

The only catch and last mile I didn't figure out is that thunderbird seems to ignore the files in /run/current-system/sw/lib/mozilla. So after installation, I manually did the following commands and could confirm it works properly:

cp /run/current-system/sw/lib/mozilla/native-messaging-hosts/SysTray_X.json ~/.mozilla/native-messaging-hosts
cp /run/current-system/sw/lib/mozilla/thunderbird-addons/extensions/systray-x@Ximi1970.xpi ~/.thunderbird/${myprofile}/extensions/

[ocfox]

But why a separate package Thunderbird extension is? No similar practice in nixpkgs.

[Zahrun]

But why a separate package Thunderbird extension is? No similar practice in nixpkgs.

The addon uses the WebExtension API's to control an external system dependent system tray application.
Needs both the addon AND the companion app installed to work.

[ocfox]

I think it should remove the extensions and just package the binary.

[Zahrun]

I think it should remove the extensions and just package the binary.

I am fine with removing the extension, which is systray-x@Ximi1970.xpi.
However, we still need the /run/current-system/sw/lib/mozilla/native-messaging-hosts/SysTray_X.json file to tell thunderbird to load the binary. When I look in that folder, I also have a file called org.kde.plasma.browser_integration.json, I think it works with Firefox. So we have a package doing this type of installation already, but not for thunderbird so far.

[Zahrun]

It seems support was added to firefox in #31572 and latest modified in ec8a9cd

I can try to replicate this for thunderbird, a very similar patch should work. Can I do this in this PR or should it be a seperate PR?

PS: Also see the related options https://search.nixos.org/options?channel=unstable&from=0&size=50&sort=relevance&type=packages&query=programs.firefox.nativeMessagingHosts

[KodyVB]

Hello, I'm curious about the status of this. Are we waiting for something with regards to this, does it conflict too much with the norms of Nix packages, or was it just forgotten over the months? As someone who's trying to switch from a distro with systray-x, I've grown very used to having it, lol. No pressure on anyone, though - I know how busy life can get

[Zahrun]

I personnaly shifted to wayland and betterbird, which now includes a systray option. I am fine with closing this PR.

[Zahrun]

@KodyVB if you want this to be merged, we would need to do something similar to #31572, which was done for Firefox, but do it for thunderbird

[KodyVB]

I didn't know about Betterbird before, but between that and the "Minimize on close" add-on, I think I'm pretty much covered and won't need to use Systray with Thunderbird. Thank you @Zahrun !