python310Packages.torchaudio: init at 2.0.1#224323
Merged
veprbl merged 1 commit intoNixOS:masterfrom Apr 7, 2023
Merged
Conversation
github-actions
bot
added
the
6.topic: python
veprbl
force-pushed
the
pr/torchaudio_init
branch
from
866a155 to
ccff013
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
veprbl
force-pushed
the
pr/torchaudio_init
branch
from
ccff013 to
1a8b325
Compare
Member
|
I'm worried that without CUDA, users will be late noticing performance issues later. |
| changelog = "https://github.com/pytorch/audio/releases/tag/v${version}"; | ||
| license = licenses.bsd2; | ||
| platforms = platforms.unix; | ||
| maintainers = with maintainers; [ junjihashimoto ]; |
Member
There was a problem hiding this comment.
Oh, I just realized that I am a maintainer.
Member
Author
There was a problem hiding this comment.
Was a copy-paste from torchaudio-bin. We can change, of course.
Member
Author
|
CUDA should be is working now. |
Member
|
If so, it is great! Thx! |
ghost
mentioned this pull request
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We already have
torchaudio-bin, this adds a source build version (a minimal one, for now).Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)