sunshine: 0.18.4 -> 0.19.1

[devusb]

Description of changes

• bump package to 0.19.1
• add new dependencies required by update
• add updater script

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[Tungsten842]

nixpkgs/pkgs/servers/sunshine/default.nix

Lines 124 to 129 in e3652e0

	CXXFLAGS = [
	"-Wno-format-security"
	];
	CFLAGS = [
	"-Wno-format-security"
	];

I thing that you can remove both of these, there doesn't seem to be a difference when compiling.

-- Checking for module 'appindicator3-0.1'
--   No package 'appindicator3-0.1' found
CMake Warning at CMakeLists.txt:437 (message):
  Couldn't find appindicator, disabling tray icon

Also libappindicator seems to be required.

[Tungsten842]

The tray icon is missing.
Also, sunshine has a desktop file can you add it to this package?

[devusb]

@Tungsten842 the tray icon works for me -- you will need to add the package to your environment (and I had to restart GNOME) for it to actually appear.

[lilyinstarlight]

If upstream ever adds lifecycle scripts (like postinstall) to package.json, you'll want --ignore-scripts on that npm i command in the updater. But given they only seem to use npm to download a small handful of deps and otherwise use CMake for everything, it doesn't seem like an actual concern here, though

Change looks good to me now. Thank you!