linuxManualConfig: add pahole to moduleBuildDependencies#222337
Merged
alyssais merged 1 commit intoNixOS:masterfrom Mar 21, 2023
Merged
Conversation
Member
Author
|
@ofborg build linuxPackages.zfs |
f617be9 to
993e831
Compare
Member
Author
|
@ofborg build linuxPackages.zfs |
Member
Author
|
Before #221707, out of tree module builds had lines like this: And then, after #221707, those lines went away, and they started failing due to not having pahole. So what happened here is that we had a bug, which was that vmlinux was not available where out-of-tree module builds expected it to be, and when I moved vmlinux so it was in the right place for the GDB scripts, I fixed that bug by accident. That introduced a new bug, which was that out-of-tree modules would try to generate BTF, but fail due to not having pahole. When I added pahole in this PR, that fixed that bug too. So I think everything is good now. |
Member
|
Just want to state that I'm very grateful for your work on this! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This seems to be needed for out-of-tree module builds since #221707. We do not yet understand why, but this will unblock the channels while we figure it out.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)