Skip to content

Comments

[staging] coreutils: 9.1 -> 9.3 and re-enable hole seeking on Darwin#222314

Merged
vcunat merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/coreutils
May 30, 2023
Merged

[staging] coreutils: 9.1 -> 9.3 and re-enable hole seeking on Darwin#222314
vcunat merged 2 commits intoNixOS:stagingfrom
helsinki-systems:upd/coreutils

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Mar 21, 2023 •
edited
Loading

Description of changes

The changes are mostly minor; numerous bugs have been fixed and a few new command-line options have been added.

Changelog: https://lists.gnu.org/archive/html/coreutils-announce/2023-03/msg00000.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 21, 2023
@dasJ dasJ changed the title [staging] coreutils: 9.1 -> 9.2 [staging] coreutils: 9.1 -> 9.2 and re-enable hole seeking on Darwin Mar 21, 2023
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 21, 2023
@ajs124
Copy link
Member

ajs124 commented Mar 23, 2023

Seems like there's a regression: https://lore.kernel.org/distributions/877cv7drmg.fsf@gentoo.org/T/#u

@mweinelt mweinelt marked this pull request as draft March 24, 2023 01:36
@dasJ dasJ changed the title [staging] coreutils: 9.1 -> 9.2 and re-enable hole seeking on Darwin [staging] coreutils: 9.1 -> 9.3 and re-enable hole seeking on Darwin Apr 19, 2023
@dasJ dasJ marked this pull request as ready for review April 19, 2023 08:47
@dasJ
Copy link
Member Author

dasJ commented Apr 19, 2023

Padraig said it should be better now ;)

@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

I don't expect this is suitable for 23.05 anymore.

dasJ added 2 commits May 1, 2023 11:13
@dasJ
coreutils: 9.1 -> 9.3
d7e6609 
The changes are mostly minor; numerous bugs have been fixed and a few
new command-line options have been added.

Changelog: https://lists.gnu.org/archive/html/coreutils-announce/2023-03/msg00000.html
@dasJ
coreutils: Re-enable hole seeking on Darwin
65366c0 
The bug appears to be resolved:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61386

See also here: openwrt/openwrt#11960 (comment)

And here: openwrt/openwrt#12233
@dasJ dasJ force-pushed the upd/coreutils branch from 2f375b9 to 65366c0 Compare May 1, 2023 09:13
@alyssais
Copy link
Member

alyssais commented May 25, 2023

Any objections to merging now?

@dasJ
Copy link
Member Author

dasJ commented May 30, 2023

I dont have any ;)

@vcunat vcunat merged commit 46e7cd1 into NixOS:staging May 30, 2023
@reckenrode reckenrode mentioned this pull request Jun 12, 2023
Merged
12 tasks
@tpwrules
Copy link
Contributor

tpwrules commented Aug 11, 2023

This seems to have caused a regression in cp with older kernels with a problematic copy_file_range call. A fix is mentioned in the latest changelogs: coreutils/coreutils@3621d51

@vcunat
Copy link
Member

vcunat commented Aug 11, 2023

Oh no, impurity in the form of build-time kernel version detection?

@tpwrules
Copy link
Contributor

tpwrules commented Aug 11, 2023 •
edited
Loading

It's unclear, using strace it looks like version 9.1 on my kernel handles the response from copy_file_range more gracefully instead of dying or skipping the call completely.

@dasJ dasJ deleted the upd/coreutils branch August 14, 2023 08:18
@vcunat
Copy link
Member

vcunat commented Sep 10, 2023 •
edited
Loading

PR #252165 should resolve that.

(I forgot the context and originally pointed you to the same NEWS item 🤦🏽)

@tpwrules tpwrules mentioned this pull request Oct 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

No open projects
Staging
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dasJ @ajs124 @vcunat @alyssais @tpwrules