Skip to content

neovimUtils: only set packpath/rtp as needed#221852

Merged
teto merged 1 commit intoNixOS:masterfrom
linsui:treesitter
Mar 19, 2023
Merged

neovimUtils: only set packpath/rtp as needed#221852
teto merged 1 commit intoNixOS:masterfrom
linsui:treesitter

Conversation

@linsui
Copy link
Copy Markdown
Contributor

@linsui linsui commented Mar 18, 2023

... when there are plugins. It doesn't make sense to set rtp to an empty directory.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

... when there are plugins
@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Mar 18, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2023
@teto
Copy link
Copy Markdown
Member

teto commented Mar 18, 2023

did you have any issue with it or you are just annoyed to see a useless folder in packpath ?

I would like to make it possible to disable as part of #205932 (for instance it will be useless in home-manager with nix-community/home-manager#3717) so I will probably refactor that one way or another later.

@linsui
Copy link
Copy Markdown
Contributor Author

linsui commented Mar 19, 2023

you are just annoyed to see a useless folder in packpath ?

This.

IIUC, your PR makes it optional. But I thought it shouldn't be added to the startupCommands at all if the directory is empty.

@teto
Copy link
Copy Markdown
Member

teto commented Mar 19, 2023

I will refactor this later. Thanks for contribution

@teto teto merged commit 7ee8aa8 into NixOS:master Mar 19, 2023
@linsui linsui deleted the treesitter branch March 19, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants