Skip to content

Revert "release.nix: don't block on aarch64-darwin bootstrap tools"#221480

Merged
wegank merged 1 commit intoNixOS:masterfrom
qowoz:stdenv-release
Mar 16, 2023
Merged

Revert "release.nix: don't block on aarch64-darwin bootstrap tools"#221480
wegank merged 1 commit intoNixOS:masterfrom
qowoz:stdenv-release

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Mar 16, 2023

This reverts commit 4d5d4a7.

builds: https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=stdenvBootstrapTools

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zowoq zowoq requested a review from vcunat March 16, 2023 12:01
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK. I haven't looked into what fixed this and such details.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 16, 2023
@wegank wegank merged commit 6eb7e56 into NixOS:master Mar 16, 2023
@zowoq zowoq deleted the stdenv-release branch March 16, 2023 22:49
@stephank
Copy link
Contributor

Thanks for this! It should indeed be fixed now, because #202347 landed on master. The regular Hydra trunk build is green, but I forgot where to check this release stuff for Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants