cargoSetupHook: use environment flags instead of config file#220660
Closed
yu-re-ka wants to merge 1 commit intoNixOS:stagingfrom
yu-re-ka:cargo-environment-flags
Closed
cargoSetupHook: use environment flags instead of config file#220660yu-re-ka wants to merge 1 commit intoNixOS:stagingfrom yu-re-ka:cargo-environment-flags
yu-re-ka wants to merge 1 commit intoNixOS:stagingfrom
yu-re-ka:cargo-environment-flags
Conversation
13 tasks
Contributor
|
Has this been tested at all? |
Contributor
Author
12 tasks
alyssais
approved these changes
Mar 16, 2023
Contributor
Author
|
Something should definitely be changed to better support non-Cargo Rust build systems, and also the dependency / vendoring logic should be separated from the rest of the flags, however I think this is no longer the way to go. A rustc wrapper or rustc setup hook is unavoidable. Also |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is necessary for the flags to apply to Firefox etc. which do not build in the sourceRoot
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)