Skip to content

release-haskell.nix: add aarch64-darwin#220487

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:release-haskell-add-aarch64-darwin
Mar 10, 2023
Merged

release-haskell.nix: add aarch64-darwin#220487
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:release-haskell-add-aarch64-darwin

Conversation

@sternenseemann
Copy link
Member

nixpkgs:trunk also builds aarch64-darwin these days, so this forces our hand a little bit. We can still refuse to care about failures too much, but at least we will stop merging as big a rebuilds as we are currently.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs:trunk also builds aarch64-darwin these days, so this forces our
hand a little bit. We can still refuse to care about failures _too_
much, but at least we will stop merging as big a rebuilds as we are
currently.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 10, 2023
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Mar 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 10, 2023
@maralorn
Copy link
Member

Nice one for choosing the green_apple. :D We had this coming eventually and even if we ignore it completely, we will on average speed up nixpkgs-unstable.

@maralorn maralorn merged commit 6fd435b into NixOS:haskell-updates Mar 10, 2023
@sternenseemann sternenseemann deleted the release-haskell-add-aarch64-darwin branch March 10, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants