matrix-sdk-crypto-nodejs: 0.1.0-beta.2 -> 0.1.0-beta.3#220317
Merged
NickCao merged 2 commits intoNixOS:masterfrom Apr 14, 2023
Merged
matrix-sdk-crypto-nodejs: 0.1.0-beta.2 -> 0.1.0-beta.3#220317NickCao merged 2 commits intoNixOS:masterfrom
NickCao merged 2 commits intoNixOS:masterfrom
Conversation
Member
|
It looks like the FOD for this package was silently broken in #221716 when it was missed and not converted I'm really not certain what the way to deal with that is, but I'm assuming this package needs to be converted to use |
5633779 to
4a0d0a7
Compare
Member
Author
Thank you, I have converted the package to use |
4a0d0a7 to
53a6395
Compare
NickCao
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The old patch does not work because commit
5dab67890cea0ab88b967031adc09179a537d77cof the repo https://github.com/Hywan/rust-indexed-db does not exist anymore.I just completely removed the
indexed_db_futures_nodejsdependency to fix the build.Remove the denepdency
indexed_db_futures_nodejsformatrix-sdk-indexeddbshould be safe as before becausecargo treeshows thatmatrix-sdk-crypto-nodejsdoes not depend onmatrix-sdk-indexeddb.cargo tree
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)