python310Packages.poetry-core: revert update of vendored dependencies#220252
Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom Mar 10, 2023
Merged
python310Packages.poetry-core: revert update of vendored dependencies#220252mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt merged 1 commit intoNixOS:staging-nextfrom
Conversation
Member
Author
|
@ofborg build python310.pkgs.zeroconf python310.pkgs.pendulum |
Member
There was a problem hiding this comment.
We don't want to apply those on all platforms? It would avoid bit rotting when updating.
Member
There was a problem hiding this comment.
We need to take this upstream either way. We can't keep applying this patch forever. For now it prevents a hefty number of rebuilds on the other three platforms. Also we don't know if this breaks anything else.
The build of zeroconf fails on x86_64-darwin with
ERROR: zeroconf-0.47.3-cp310-cp310-macosx_13_0_x86_64.whl is not a
supported wheel on this platform.
using the newer versions of the vendored dependencies.
e925ef3 to
baf91ea
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The build of zeroconf fails on x86_64-darwin with
using the newer versions of the vendored dependencies.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)