Skip to content

python310Packages.poetry-core: revert update of vendored dependencies#220252

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
dotlambda:poetry-core-x86_64-darwin
Mar 10, 2023
Merged

python310Packages.poetry-core: revert update of vendored dependencies#220252
mweinelt merged 1 commit intoNixOS:staging-nextfrom
dotlambda:poetry-core-x86_64-darwin

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 9, 2023

Description of changes

The build of zeroconf fails on x86_64-darwin with

ERROR: zeroconf-0.47.3-cp310-cp310-macosx_13_0_x86_64.whl is not a supported wheel on this platform.

using the newer versions of the vendored dependencies.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested review from K900 and mweinelt March 9, 2023 01:58
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 9, 2023
@ofborg ofborg bot requested a review from jonringer March 9, 2023 02:12
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 9, 2023
@dotlambda
Copy link
Member Author

@ofborg build python310.pkgs.zeroconf python310.pkgs.pendulum

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to apply those on all platforms? It would avoid bit rotting when updating.

Copy link
Member

@mweinelt mweinelt Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to take this upstream either way. We can't keep applying this patch forever. For now it prevents a hefty number of rebuilds on the other three platforms. Also we don't know if this breaks anything else.

The build of zeroconf fails on x86_64-darwin with

    ERROR: zeroconf-0.47.3-cp310-cp310-macosx_13_0_x86_64.whl is not a
    supported wheel on this platform.

using the newer versions of the vendored dependencies.
@dotlambda dotlambda force-pushed the poetry-core-x86_64-darwin branch from e925ef3 to baf91ea Compare March 9, 2023 16:11
@mweinelt mweinelt merged commit 83ac46c into NixOS:staging-next Mar 10, 2023
@dotlambda dotlambda deleted the poetry-core-x86_64-darwin branch March 11, 2023 13:01
@natsukium natsukium mentioned this pull request May 31, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants