Skip to content

Nodejs 18 arm64#220013

Closed
Cynerd wants to merge 1 commit intoNixOS:stagingfrom
Cynerd:nodejs-18-arm64
Closed

Nodejs 18 arm64#220013
Cynerd wants to merge 1 commit intoNixOS:stagingfrom
Cynerd:nodejs-18-arm64

Conversation

@Cynerd
Copy link
Contributor

@Cynerd Cynerd commented Mar 7, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Cynerd Cynerd requested review from FRidh and jonringer as code owners March 7, 2023 16:57
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 7, 2023
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 7, 2023
@ofborg ofborg bot requested a review from SuperSandro2000 March 7, 2023 17:13
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 7, 2023
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 8, 2023

This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

@mweinelt mweinelt marked this pull request as draft March 8, 2023 01:57
@mweinelt
Copy link
Member

mweinelt commented Mar 8, 2023 •
edited
Loading

Looks like this PR also contains two unrelated commits. Please clean up the branch while rebasing.

Please update the PR description and split the python changes off into a separate PR.

@Cynerd Cynerd changed the base branch from master to staging March 8, 2023 07:44
@Cynerd
nodejs-18_x: apply aarch64 cross building patch
be2bcab 
The version 18 also contains this patch and thus breaks aarch64 cross
compilation.
@Cynerd Cynerd force-pushed the nodejs-18-arm64 branch from eef336a to be2bcab Compare March 8, 2023 07:45
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 8, 2023
@Cynerd
Copy link
Contributor Author

Cynerd commented Mar 8, 2023

Looks like this PR also contains two unrelated commits. Please clean up the branch while rebasing.

Please update the PR description and split the python changes off into a separate PR.

Sorry. I missed that I wasn't based it on clean master. Those are actually already submitted in here #212795.

@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 8, 2023
@marsam
Copy link
Contributor

marsam commented Mar 8, 2023

Addressed by #220107

@marsam marsam closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Artturin Artturin Awaiting requested review from Artturin

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cynerd @SuperSandro2000 @mweinelt @marsam