neovimUtils.makeNeovimConfig: expose packpathsDir#218786
Merged
teto merged 1 commit intoNixOS:masterfrom Feb 28, 2023
Merged
Conversation
this way home-manager can link the packpathDir in ~/.local/share/nvim/site which makes package discovery work without needing to `set packpath` (making the wrapper further useless).
7 tasks
Member
|
@teto You waited a total of 1 minute to merge this PR. You didn't even wait for any github action nor ofborg to finish. As there is no urgency for this change, this is not acceptable. Please stop doing such rush merges in the future. Also regarding your commit message: neovim should stay usable within NixOS and without home-manager but making the package easier to use for home-manager is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this way home-manager can link the packpathDir in
~/.local/share/nvim/site which makes package discovery work without
needing to
set packpath(making the wrapper further useless).Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)