Skip to content

haskell-updates: update Hackage, in particular Cabal-3.8.1.0#218740

Closed
peterbecich wants to merge 1 commit intoNixOS:haskell-updatesfrom
peterbecich:update-hackage
Closed

haskell-updates: update Hackage, in particular Cabal-3.8.1.0#218740
peterbecich wants to merge 1 commit intoNixOS:haskell-updatesfrom
peterbecich:update-hackage

Conversation

@peterbecich
Copy link
Contributor

@peterbecich peterbecich commented Feb 28, 2023

Description of changes

produced with

./maintainers/scripts/haskell/update-stackage.sh
./maintainers/scripts/haskell/update-hackage.sh
./maintainers/scripts/haskell/regenerate-hackage-packages.sh

I am trying to get revision 2 of Cabal-3.8.1.0 into the package set: https://hackage.haskell.org/package/Cabal-3.8.1.0/revisions/

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 28, 2023
@peterbecich peterbecich marked this pull request as draft February 28, 2023 05:45
@peterbecich peterbecich marked this pull request as ready for review February 28, 2023 06:02
@sternenseemann
Copy link
Member

Looks like we are in good shape and haskell-updates can be merged in the next days. After that we'll start another regular rotation. We are seemingly all a bit short on time at the moment, so things are going a bit slower than usual.

I am trying to get revision 2 of `Cabal-3.8.1.0` into the package set: https://hackage.haskell.org/package/Cabal-3.8.1.0/revisions/

```
./maintainers/scripts/haskell/update-stackage.sh
./maintainers/scripts/haskell/update-hackage.sh
./maintainers/scripts/haskell/regenerate-hackage-packages.sh
```
@peterbecich
Copy link
Contributor Author

peterbecich commented Mar 1, 2023

@sternenseemann , thanks, can we include

       pname = "Cabal";
       version = "3.8.1.0";
       sha256 = "0236fddzhalsr2gjbjsk92rgh8866fks28r04g8fbmzkqbkcnr3l";
       revision = "2";

https://github.com/NixOS/nixpkgs/blob/645175db2b2ecb4032005b2c24ff023d44cb6320/pkgs/development/haskell-modules/hackage-packages.nix#L2910-L2913 before haskell-updates is merged?

Should I slim down this PR to just this single change? Should I close the PR?

sternenseemann added a commit that referenced this pull request Mar 1, 2023
@sternenseemann
Copy link
Member

See #217111/#219027

@peterbecich
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants